Project

Profile

Help

Task #2907

closed

Remove plugin API objects that are not used by core

Added by bmbouter over 7 years ago. Updated about 5 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
High
Assignee:
Category:
-
Sprint/Milestone:
Start date:
Due date:
% Done:

100%

Estimated time:
Platform Release:
Groomed:
Yes
Sprint Candidate:
Yes
Tags:
Sprint:
Sprint 23
Quarter:

Description

The plugin API has several placeholder objects that are not used by the plugin. It's very possible these objects won't be in the GA release even based on the MVP. Specifically these objects:

Cataloger
Profiler

We also need to remove almost all or all of the serializers and viewsets which are currently mass-imported into pulpcore.plugin.

Only bring in viewsets and serializers that the plugin writer is intended to subclass. That would involve changing these two imports:

viewsets.py
serializers.py

Those two modules should only importer the following objects by name (not with *):

pulpcore.plugin.serializers.ContentSerializer
pulpcore.plugin.serializers.ImporterSerializer
pulpcore.plugin.serializers.PublisherSerializer
pulpcore.plugin.viewsets.ContentViewSet
pulpcore.plugin.viewsets.ImporterViewSet
pulpcore.plugin.viewsets.PublisherViewSet
Actions #1

Updated by dkliban@redhat.com over 7 years ago

dkliban will groom

Actions #2

Updated by amacdona@redhat.com over 7 years ago

We will still need to import master ViewSets and Serializers that the plugins inherit from.

At a minimum, we need to keep:

  • pulpcore.plugin.serializers.ContentSerializer
  • pulpcore.plugin.serializers.ImporterSerializer
  • pulpcore.plugin.serializers.PublisherSerializer
  • pulpcore.plugin.viewsets.ContentViewSet
  • pulpcore.plugin.viewsets.ImporterViewSet
  • pulpcore.plugin.viewsets.PublisherViewSet
Actions #3

Updated by bmbouter over 7 years ago

  • Description updated (diff)

@asmacdo, I agree. I also think those are the base minimum set so that plugin writers can inherit from them.

Actions #4

Updated by dkliban@redhat.com over 7 years ago

  • Groomed changed from No to Yes
  • Sprint Candidate changed from No to Yes
Actions #5

Updated by mhrivnak over 7 years ago

  • Priority changed from Normal to High
Actions #6

Updated by mhrivnak over 7 years ago

  • Sprint/Milestone set to 42
Actions #7

Updated by bizhang over 7 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to bizhang
Actions #8

Updated by bizhang over 7 years ago

  • Status changed from ASSIGNED to POST
Actions #9

Updated by werwty over 7 years ago

  • Status changed from POST to MODIFIED
  • % Done changed from 0 to 100
Actions #10

Updated by bmbouter about 7 years ago

  • Tags deleted (Pulp 3 Plugin Writer Alpha)

Cleaning up Redmine tags

Actions #11

Updated by bmbouter almost 7 years ago

  • Sprint set to Sprint 23
Actions #12

Updated by bmbouter almost 7 years ago

  • Sprint/Milestone deleted (42)
Actions #13

Updated by daviddavis over 5 years ago

  • Sprint/Milestone set to 3.0.0
Actions #14

Updated by bmbouter over 5 years ago

  • Tags deleted (Pulp 3)
Actions #15

Updated by bmbouter about 5 years ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE

Also available in: Atom PDF