Task #2907
Remove plugin API objects that are not used by core
100%
Description
The plugin API has several placeholder objects that are not used by the plugin. It's very possible these objects won't be in the GA release even based on the MVP. Specifically these objects:
We also need to remove almost all or all of the serializers and viewsets which are currently mass-imported into pulpcore.plugin.
Only bring in viewsets and serializers that the plugin writer is intended to subclass. That would involve changing these two imports:
Those two modules should only importer the following objects by name (not with *):
pulpcore.plugin.serializers.ContentSerializer
pulpcore.plugin.serializers.ImporterSerializer
pulpcore.plugin.serializers.PublisherSerializer
pulpcore.plugin.viewsets.ContentViewSet
pulpcore.plugin.viewsets.ImporterViewSet
pulpcore.plugin.viewsets.PublisherViewSet
Associated revisions
Revision 61f13841
View on GitHub
Clean up plugin API
History
#1
Updated by dkliban@redhat.com over 3 years ago
dkliban will groom
#2
Updated by amacdona@redhat.com over 3 years ago
We will still need to import master ViewSets and Serializers that the plugins inherit from.
At a minimum, we need to keep:
- pulpcore.plugin.serializers.ContentSerializer
- pulpcore.plugin.serializers.ImporterSerializer
- pulpcore.plugin.serializers.PublisherSerializer
- pulpcore.plugin.viewsets.ContentViewSet
- pulpcore.plugin.viewsets.ImporterViewSet
- pulpcore.plugin.viewsets.PublisherViewSet
#3
Updated by bmbouter over 3 years ago
- Description updated (diff)
@asmacdo, I agree. I also think those are the base minimum set so that plugin writers can inherit from them.
#4
Updated by dkliban@redhat.com over 3 years ago
- Groomed changed from No to Yes
- Sprint Candidate changed from No to Yes
#5
Updated by mhrivnak over 3 years ago
- Priority changed from Normal to High
#6
Updated by mhrivnak over 3 years ago
- Sprint/Milestone set to 42
#7
Updated by bizhang over 3 years ago
- Status changed from NEW to ASSIGNED
- Assignee set to bizhang
#8
Updated by bizhang over 3 years ago
- Status changed from ASSIGNED to POST
#9
Updated by werwty over 3 years ago
- Status changed from POST to MODIFIED
- % Done changed from 0 to 100
Applied in changeset pulp|61f138412146be235799f2008bf678a27daf9bb4.
#10
Updated by bmbouter about 3 years ago
- Tags deleted (
Pulp 3 Plugin Writer Alpha)
Cleaning up Redmine tags
#11
Updated by bmbouter almost 3 years ago
- Sprint set to Sprint 23
#12
Updated by bmbouter almost 3 years ago
- Sprint/Milestone deleted (
42)
#13
Updated by daviddavis over 1 year ago
- Sprint/Milestone set to 3.0.0
#14
Updated by bmbouter over 1 year ago
- Tags deleted (
Pulp 3)
#15
Updated by bmbouter about 1 year ago
- Status changed from MODIFIED to CLOSED - CURRENTRELEASE
Please register to edit this issue
Clean up plugin API
closes #2907 https://pulp.plan.io/issues/2907