Project

Profile

Help

Story #2889

closed

As an authenticated user, I can view a task's name and search for tasks based on their names.

Added by daviddavis almost 7 years ago. Updated over 4 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
Category:
-
Sprint/Milestone:
Start date:
Due date:
% Done:

100%

Estimated time:
Platform Release:
Groomed:
Yes
Sprint Candidate:
Yes
Tags:
Sprint:
Sprint 47
Quarter:

Related issues

Related to Pulp - Test #4230: Test task name and search for task based on their nameCLOSED - COMPLETErochacbrunoActions
Actions #1

Updated by daviddavis almost 7 years ago

For more info, see the proposed implementation at https://pulp.plan.io/issues/2482#note-11

Actions #2

Updated by amacdona@redhat.com over 5 years ago

  • Tags Pulp 3 RC Blocker added

This one needs to be groomed and accepted on the sprint before anyone starts working on it because this would be a backwards incompatible change for plugins. For the same reason, I am adding this as an RC Blocker.

Actions #3

Updated by kersom over 5 years ago

Actions #4

Updated by kersom over 5 years ago

  • Related to Test #4230: Test task name and search for task based on their name added
Actions #5

Updated by daviddavis over 5 years ago

I think we should set task name on the tasks here:

https://github.com/pulp/pulp/blob/cf30f2e9a77f7ad935184c5cbe58dfad788febc3/pulpcore/tasking/tasks.py#L188

I think for now we should just use the func name with module name similar to here:

https://github.com/pulp/pulp/blob/cf30f2e9a77f7ad935184c5cbe58dfad788febc3/pulpcore/tasking/tasks.py#L78

In the future we could maybe give plugin writers the option to override task name when calling enqueue_with_reservation by passing in a name kwarg. This unleashes its own set of problems (namespacing, etc) so I am kind of dubious about doing so.

Actions #6

Updated by bmbouter over 5 years ago

  • Groomed changed from No to Yes
  • Sprint Candidate changed from No to Yes

I think this story covers all of the aspects.

Actions #7

Updated by bmbouter over 5 years ago

  • Sprint set to Sprint 47
Actions #8

Updated by ppicka over 5 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to ppicka
Actions #9

Updated by ttereshc over 5 years ago

Actions #10

Updated by ppicka over 5 years ago

Actions #11

Updated by bmbouter over 5 years ago

Determining which names to set for existing or already completed tasks is difficult at best and probably practically impossible in some cases. Since Pulp is pre-production, the migration that adds the field can set existing tasks to default defined in the migration and not have to determine the value for all existing tasks in a smart way.

Also as an aside, since all tasks will have this I think the field is required and can't have a field default. Since it would be required the migration default should be '' not None. (my opinion).

Actions #12

Updated by daviddavis over 5 years ago

+1

Actions #13

Updated by ppicka over 5 years ago

  • Status changed from ASSIGNED to POST

Added by ppicka over 5 years ago

Revision 7fef6b7d | View on GitHub

Adding names to tasks

User can see and filter the class path and function name which run inside the task.

closes: #2889 https://pulp.plan.io/issues/2889

Signed-off-by: Pavel Picka

Added by ppicka over 5 years ago

Revision 7fef6b7d | View on GitHub

Adding names to tasks

User can see and filter the class path and function name which run inside the task.

closes: #2889 https://pulp.plan.io/issues/2889

Signed-off-by: Pavel Picka

Actions #14

Updated by ppicka over 5 years ago

  • Status changed from POST to MODIFIED
  • % Done changed from 0 to 100
Actions #15

Updated by daviddavis almost 5 years ago

  • Sprint/Milestone set to 3.0.0
Actions #16

Updated by bmbouter almost 5 years ago

  • Tags deleted (Pulp 3, Pulp 3 RC Blocker)
Actions #17

Updated by bmbouter over 4 years ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE

Also available in: Atom PDF