Project

Profile

Help

Actions
Send by e-mail Copy link

Task #2816

closed

Rename importer auth fields

Added by amacdona@redhat.com over 7 years ago. Updated almost 5 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
amacdona@redhat.com
Category:
-
Sprint/Milestone:
3.0.0
Start date:
Due date:
% Done:

100%

Estimated time:
Platform Release:
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:
Quarter:

Description

basic_auth_username and basic_auth_password are useful for more than just basic auth. Rename those fields to reflect.

Some ideas:
remote_username
username

Related issues

Related to Pulp - Task #2818: Align existing code base with importer attributes from the MVPCLOSED - CURRENTRELEASEamacdona@redhat.com

Actions
Actions
Copy link
 #1

Updated by bmbouter over 7 years ago

  • Description updated (diff)

I think we should use username and password. I think remote_username is useful for disambiguating a remote versus local_username, which we don't have.

Actions
Copy link
 #2

Updated by bmbouter over 7 years ago

Actually we do have a proxy_pass which also takes a username and password embedded in the url. Perhaps using remote_username and remote_password would be good. I'd like to hear what others think.

Actions
Copy link
 #3

Updated by bmbouter over 7 years ago

  • Description updated (diff)
Actions
Copy link
 #4

Updated by mhrivnak over 7 years ago

I like the simplicity of "username" and "password". I don't think anyone will be confused about what they mean, especially given a succinct line of documentation.

Actions
Copy link
 #5

Updated by dkliban@redhat.com over 7 years ago

"username" and p"password" are most appropriate.

Actions
Copy link
 #6

Updated by amacdona@redhat.com over 7 years ago

  • Related to Task #2818: Align existing code base with importer attributes from the MVP added
Actions
Copy link
 #7

Updated by amacdona@redhat.com over 7 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to amacdona@redhat.com
Actions
Copy link
 #8

Updated by amacdona@redhat.com over 7 years ago

  • Status changed from ASSIGNED to POST
Actions
Copy link
 #9

Updated by amacdona@redhat.com about 7 years ago

  • Status changed from POST to MODIFIED
  • % Done changed from 0 to 100
Actions
Copy link
 #10

Updated by daviddavis over 5 years ago

  • Sprint/Milestone set to 3.0.0
Actions
Copy link
 #11

Updated by bmbouter over 5 years ago

  • Tags deleted (Pulp 3)
Actions
Copy link
 #12

Updated by bmbouter almost 5 years ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE
Actions
Send by e-mail Copy link

Also available in: Atom PDF