Issue #2768
closed
Worker foreign key does not get associated with task in Pulp3
Description
When a task is kicked off I would expect it to populate the worker foreign key [0] when the task is ran
I would expect this to be updated in the apply_async function when the Task status object is created [1].
Tasks kicked off with apply_async should have the worker field populated upon creation.
Tasks kicked off with apply_async_with_reservations would have the worker field updated when it gets routed to the worker.
For reference pulp2 updates the field here [2]
[0] https://github.com/pulp/pulp/blob/b3ff9a93bba4af1405f57e907944270b3052668a/platform/pulp/app/models/task.py#L158
[1] https://github.com/pulp/pulp/blob/b3ff9a93bba4af1405f57e907944270b3052668a/platform/pulp/tasking/tasks.py#L243
[2] https://github.com/pulp/pulp/blob/master/server/pulp/server/async/tasks.py#L484
Updated by bizhang over 7 years ago
- Subject changed from Worker foreign key does not get associated with task to Worker foreign key does not get associated with task in Pulp3
Updated by ttereshc over 7 years ago
- Sprint/Milestone set to 39
- Groomed changed from No to Yes
Updated by ttereshc over 7 years ago
- Triaged changed from No to Yes
- Groomed changed from Yes to No
Updated by bmbouter over 7 years ago
- Sprint/Milestone deleted (
39)
I thought about this more, and I think this is the patch we need. We should only set the worker in the _queue_reserve_resource task because that is the earliest moment the worker is known and that is the only time in all of Pulp that a task is dispatched to a dedicated worker.
diff --git a/platform/pulp/tasking/tasks.py b/platform/pulp/tasking/tasks.py
index cd0e21b..41c6890 100644
--- a/platform/pulp/tasking/tasks.py
+++ b/platform/pulp/tasking/tasks.py
@@ -87,6 +87,9 @@ def _queue_reserved_task(name, inner_task_id, resource_id, inner_args, inner_kwa
time.sleep(0.25)
task_status = TaskStatus.objects.get(pk=inner_task_id)
+ task_status.worker = worker
+ task_status.save()
+
ReservedResource.objects.create(task=task_status, worker=worker, resource=resource_id)
inner_kwargs['routing_key'] = worker.name
Updated by bizhang over 7 years ago
https://pulp.plan.io/issues/2768#note-6 would only associate the worker when the task is called with apply_async_with_reservation. This is an issues that also exists in pulp2
As discussed with bmbouter the change should be made in https://github.com/pulp/pulp/blob/b3ff9a93bba4af1405f57e907944270b3052668a/platform/pulp/tasking/tasks.py#L255
Since __call__() is called on the worker itself, worker name should be one of the *args or **kwargs
Updated by dalley over 7 years ago
- Status changed from NEW to ASSIGNED
- Assignee set to dalley
Updated by dalley over 7 years ago
- Status changed from ASSIGNED to POST
PR is up
https://github.com/pulp/pulp/pull/3054
Commands to test:
from pulpcore.app.tasks import repository
from pulpcore.app.models import Repository
import uuid
repo_uuid=str(uuid.uuid4())
repo=Repository(name=repo_uuid)
repo.save()
repository.delete.apply_async(kwargs={'repo_name':repo_uuid})
repository.delete.apply_async_with_reservation("foo","bar",kwargs={'repo_name':repo_uuid})
Added by dalley over 7 years ago
Added by dalley over 7 years ago
Revision b00649ec | View on GitHub
Associate worker foreign key with task
Ensure the worker field on the Task model gets populated.
Updated by dalley over 7 years ago
- Status changed from POST to MODIFIED
Applied in changeset pulp|b00649ec5c96b8c62985145f456ea9872ee9d6d9.
Updated by bmbouter about 5 years ago
- Status changed from MODIFIED to CLOSED - CURRENTRELEASE
.
Associate worker foreign key with task
Ensure the worker field on the Task model gets populated.
closes #2768 https://pulp.plan.io/issues/2768