Story #2691
closed
As a user, I can verify if content exists on a disk during publish
Description
In the case when something bad happened and files in /var/lib/pulp/content got lost, pulp publishes
repo with links pointing to non-existing files.
source server/pulp/plugins/util/misc.py
function create_symlink
if symlink exists and it's parent directory exists, function returns here:
https://github.com/pulp/pulp/blob/master/server/pulp/plugins/util/misc.py#L107
with no validation of source.
- Tracker changed from Issue to Story
- Subject changed from Pulp should verify if source for link exists to As a user, I can verify if content exists on a disk during publish
- % Done set to 0
Several points from the IRC discussion:
1. There are valid cases when symlink can point to non-existing file, like on_demand case.
2. Several people pointed out that publish may not be a good time to validate content and it is better to do at sync time.
3. I personally think that with operational sync, content on a filesystem will be back.
When there is an optimization not to download already existing content we check if file exists on a filesystem. If there is no such optimization, content will be downloaded and moved to its final destination in any case. So one can fix /v/l/p/content with force syncs.
- Status changed from NEW to CLOSED - WONTFIX
Pulp 2 is approaching maintenance mode, and this Pulp 2 ticket is not being actively worked on. As such, it is being closed as WONTFIX. Pulp 2 is still accepting contributions though, so if you want to contribute a fix for this ticket, please reopen or comment on it. If you don't have permissions to reopen this ticket, or you want to discuss an issue, please reach out via the developer mailing list.
Also available in: Atom
PDF
.