Issue #2630
closed
disassociate_units updates last_unit_removed timestamp even if no units are removed
Description
This[0] fix introduced a minor regression, by which the 'last_unit_removed' timestamp is updated whenever disassociate_units was called, even if that call removes no units. Since it's acceptable for disassociate_units to be called with unevaluated generators that generate nothing or otherwise empty iterables, that function should only update 'last_unit_removed' when units are actually removed.
[0]: https://github.com/pulp/pulp/commit/10d651cf44d26b97f777f8b4c237b12c480cdf52
Related issues
Updated by semyers about 7 years ago
- Status changed from NEW to POST
I found this while going over smash results for 2.12.2 Beta 1 with jaudet. In the process of figuring out what was going wrong, it was also pretty clear how to fix it:
Updated by semyers about 7 years ago
- Related to Issue #1389: Disallow re-uploading the same package twice added
Added by semyers about 7 years ago
Added by semyers about 7 years ago
Revision 45ed6e6e | View on GitHub
Only update last_unit_removed when units are removed
Updated by semyers about 7 years ago
- Status changed from POST to MODIFIED
Applied in changeset pulp|45ed6e6e3b46a1ad41d5d8ba56f0e9389aaf2f55.
Updated by semyers about 7 years ago
- Status changed from MODIFIED to 5
- Platform Release set to 2.12.2
redmine fail, this is included in 2.12.2 and should be ON_QA
Updated by bizhang about 7 years ago
- Status changed from 5 to CLOSED - CURRENTRELEASE
.
Only update last_unit_removed when units are removed
closes #2630 https://pulp.plan.io/issues/2630