Project

Profile

Help

Issue #2630

disassociate_units updates last_unit_removed timestamp even if no units are removed

Added by semyers 7 months ago. Updated 6 months ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Urgent
Assignee:
Category:
-
Sprint/Milestone:
Severity:
1. Low
Version:
Platform Release:
2.12.2
Blocks Release:
2.12.z, 2.13.z
OS:
Backwards Incompatible:
No
Triaged:
No
Groomed:
No
Sprint Candidate:
No
Tags:
QA Contact:
Complexity:
Smash Test:
Verified:
No
Verification Required:
No

Description

This0 fix introduced a minor regression, by which the 'last_unit_removed' timestamp is updated whenever disassociate_units was called, even if that call removes no units. Since it's acceptable for disassociate_units to be called with unevaluated generators that generate nothing or otherwise empty iterables, that function should only update 'last_unit_removed' when units are actually removed.

[0]: https://github.com/pulp/pulp/commit/10d651cf44d26b97f777f8b4c237b12c480cdf52


Related issues

Related to Pulp - Issue #1389: Disallow re-uploading the same package twice CLOSED - CURRENTRELEASE Actions

Associated revisions

Revision 45ed6e6e View on GitHub
Added by semyers 7 months ago

Only update last_unit_removed when units are removed

closes #2630
https://pulp.plan.io/issues/2630

History

#1 Updated by semyers 7 months ago

  • Status changed from NEW to POST

I found this while going over smash results for 2.12.2 Beta 1 with jaudet. In the process of figuring out what was going wrong, it was also pretty clear how to fix it:

https://github.com/pulp/pulp/pull/2963

#2 Updated by semyers 7 months ago

  • Description updated (diff)

#3 Updated by semyers 7 months ago

  • Related to Issue #1389: Disallow re-uploading the same package twice added

#4 Updated by semyers 7 months ago

  • Description updated (diff)

#5 Updated by semyers 7 months ago

  • Status changed from POST to MODIFIED

#6 Updated by ttereshc 7 months ago

  • Sprint/Milestone set to Sprint 16

#7 Updated by semyers 7 months ago

  • Status changed from MODIFIED to ON_QA
  • Platform Release set to 2.12.2

redmine fail, this is included in 2.12.2 and should be ON_QA

#8 Updated by pthomas@redhat.com 7 months ago

  • Smash Test set to 601

#9 Updated by bizhang 6 months ago

  • Status changed from ON_QA to CLOSED - CURRENTRELEASE

Please register to edit this issue

Also available in: Atom PDF