Project

Profile

Help

Task #2275

Configure Celery to log using the Pulp syslog handler

Added by bmbouter about 3 years ago. Updated 6 months ago.

Status:
MODIFIED
Priority:
Normal
Assignee:
Category:
-
Sprint/Milestone:
Start date:
Due date:
% Done:

100%

Platform Release:
Blocks Release:
Backwards Incompatible:
No
Groomed:
Yes
Sprint Candidate:
Yes
Tags:
QA Contact:
Complexity:
Smash Test:
Verified:
No
Verification Required:
No
Sprint:
Sprint 17

Description

In The 2.y line Celery uses a signal to install the logging handler inside of Celery processes. We need to port the installation to 3.0. The signal handler itself has already been ported to 3.0-dev and now lives here0.

The signal handler on the 2.y line was imported with this line2. Note that pulp.server.async.app is now pulp.tasking.celery_app so the noqa import should occur there.

[0]: https://github.com/pulp/pulp/blob/523677d7244b7f3da98e47b7214d3e2c228efee9/app/pulp/app/logs.py#L15
[1]: https://github.com/pulp/pulp/blob/6837b902f9babdab26c3dae3ab49f975b591ae63/server/pulp/server/logs.py#L34-L73
[2]: https://github.com/pulp/pulp/blob/33ce8590f6112c2101930e23f0470c1883ef98a7/server/pulp/server/async/app.py#L27


Checklist


Related issues

Blocked by Pulp - Refactor #2154: Convert task system to use django models MODIFIED Actions

Associated revisions

Revision 8bead7b1 View on GitHub
Added by fdobrovo over 2 years ago

Set celery logger to pulp logger

closes #2275
https://pulp.plan.io/issues/2275

Revision 8bead7b1 View on GitHub
Added by fdobrovo over 2 years ago

Set celery logger to pulp logger

closes #2275
https://pulp.plan.io/issues/2275

Revision 8bead7b1 View on GitHub
Added by fdobrovo over 2 years ago

Set celery logger to pulp logger

closes #2275
https://pulp.plan.io/issues/2275

History

#1 Updated by bmbouter about 3 years ago

  • Blocked by Refactor #2154: Convert task system to use django models added

#2 Updated by bmbouter about 3 years ago

  • Description updated (diff)

#3 Updated by amacdona@redhat.com about 3 years ago

  • Groomed changed from No to Yes

#4 Updated by mhrivnak about 3 years ago

  • Sprint/Milestone set to 27

#5 Updated by bmbouter about 3 years ago

This story is written at a very low level. To express what is really important it is that the celery logs need to be handled the same way that pulp logs all non-celery stuff.

#6 Updated by fdobrovo about 3 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to fdobrovo

#7 Updated by jortel@redhat.com almost 3 years ago

  • Sprint/Milestone changed from 27 to 28

#9 Updated by fdobrovo almost 3 years ago

  • Status changed from ASSIGNED to POST

#10 Updated by mhrivnak almost 3 years ago

  • Sprint/Milestone changed from 28 to 29

#11 Updated by bmbouter almost 3 years ago

  • Checklist item test logging from pulp_celerybeat added
  • Checklist item test logging from pulp_resource_manager added
  • Checklist item test_logging from a pulp worker added
  • Checklist item remove pulp.app.logs and any imports+comments referencing it added

I'm adding some checklist items to this.

Note that we had written a custom logger which on 3.0-dev is current housed at pulp.app.logs

I wrote this story originally to configure the logger at pulp.app.logs, but from the PR posted I think replacing our custom logger with the Django logger itself may be better. I would be very surprised if our custom logger was better than the Django logger.

See this related convo: https://github.com/pulp/pulp/pull/2862/files#r89887158

#12 Updated by bmbouter almost 3 years ago

  • Sprint/Milestone changed from 29 to 30

This is at POST but it needs more work so moving to Sprint 12.

#13 Updated by mhrivnak over 2 years ago

  • Sprint/Milestone changed from 30 to 36

#14 Updated by fdobrovo over 2 years ago

  • Status changed from POST to MODIFIED
  • % Done changed from 0 to 100

#15 Updated by bmbouter over 1 year ago

  • Sprint set to Sprint 17

#16 Updated by bmbouter over 1 year ago

  • Sprint/Milestone deleted (36)

#17 Updated by daviddavis 6 months ago

  • Sprint/Milestone set to 3.0

#18 Updated by bmbouter 6 months ago

  • Tags deleted (Pulp 3)

Please register to edit this issue

Also available in: Atom PDF