Task #2275
closed
Configure Celery to log using the Pulp syslog handler
100%
Description
In The 2.y line Celery uses a signal to install the logging handler inside of Celery processes. We need to port the installation to 3.0. The signal handler itself has already been ported to 3.0-dev and now lives here[0].
The signal handler on the 2.y line was imported with this line[2]. Note that pulp.server.async.app is now pulp.tasking.celery_app so the noqa import should occur there.
[0]: https://github.com/pulp/pulp/blob/523677d7244b7f3da98e47b7214d3e2c228efee9/app/pulp/app/logs.py#L15
[1]: https://github.com/pulp/pulp/blob/6837b902f9babdab26c3dae3ab49f975b591ae63/server/pulp/server/logs.py#L34-L73
[2]: https://github.com/pulp/pulp/blob/33ce8590f6112c2101930e23f0470c1883ef98a7/server/pulp/server/async/app.py#L27
Related issues
Updated by bmbouter over 8 years ago
- Blocked by Refactor #2154: Convert task system to use django models added
Updated by bmbouter about 8 years ago
This story is written at a very low level. To express what is really important it is that the celery logs need to be handled the same way that pulp logs all non-celery stuff.
Updated by fdobrovo about 8 years ago
- Status changed from NEW to ASSIGNED
- Assignee set to fdobrovo
Updated by jortel@redhat.com about 8 years ago
- Sprint/Milestone changed from 27 to 28
Updated by fdobrovo about 8 years ago
Updated by bmbouter about 8 years ago
I'm adding some checklist items to this.
Note that we had written a custom logger which on 3.0-dev is current housed at pulp.app.logs
I wrote this story originally to configure the logger at pulp.app.logs, but from the PR posted I think replacing our custom logger with the Django logger itself may be better. I would be very surprised if our custom logger was better than the Django logger.
See this related convo: https://github.com/pulp/pulp/pull/2862/files#r89887158
Updated by bmbouter about 8 years ago
- Sprint/Milestone changed from 29 to 30
This is at POST but it needs more work so moving to Sprint 12.
Added by fdobrovo over 7 years ago
Added by fdobrovo over 7 years ago
Revision 8bead7b1 | View on GitHub
Set celery logger to pulp logger
Updated by fdobrovo over 7 years ago
- Status changed from POST to MODIFIED
- % Done changed from 0 to 100
Applied in changeset pulp|8bead7b19cf40e1b54bf9fd9658d14c4e28420df.
Updated by bmbouter about 5 years ago
- Status changed from MODIFIED to CLOSED - CURRENTRELEASE
.
Set celery logger to pulp logger
closes #2275 https://pulp.plan.io/issues/2275