Project

Profile

Help

Task #2275

closed

Configure Celery to log using the Pulp syslog handler

Added by bmbouter over 7 years ago. Updated over 2 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
Category:
-
Sprint/Milestone:
Start date:
Due date:
% Done:

100%

Estimated time:
Platform Release:
Groomed:
Yes
Sprint Candidate:
Yes
Tags:
Sprint:
Sprint 17
Quarter:

Description

In The 2.y line Celery uses a signal to install the logging handler inside of Celery processes. We need to port the installation to 3.0. The signal handler itself has already been ported to 3.0-dev and now lives here[0].

The signal handler on the 2.y line was imported with this line[2]. Note that pulp.server.async.app is now pulp.tasking.celery_app so the noqa import should occur there.

[0]: https://github.com/pulp/pulp/blob/523677d7244b7f3da98e47b7214d3e2c228efee9/app/pulp/app/logs.py#L15
[1]: https://github.com/pulp/pulp/blob/6837b902f9babdab26c3dae3ab49f975b591ae63/server/pulp/server/logs.py#L34-L73
[2]: https://github.com/pulp/pulp/blob/33ce8590f6112c2101930e23f0470c1883ef98a7/server/pulp/server/async/app.py#L27


Related issues

Blocked by Pulp - Refactor #2154: Convert task system to use django modelsCLOSED - CURRENTRELEASEbmbouter

Actions
Actions #1

Updated by bmbouter over 7 years ago

  • Blocked by Refactor #2154: Convert task system to use django models added
Actions #2

Updated by bmbouter over 7 years ago

  • Description updated (diff)
Actions #3

Updated by amacdona@redhat.com over 7 years ago

  • Groomed changed from No to Yes
Actions #4

Updated by mhrivnak over 7 years ago

  • Sprint/Milestone set to 27
Actions #5

Updated by bmbouter over 7 years ago

This story is written at a very low level. To express what is really important it is that the celery logs need to be handled the same way that pulp logs all non-celery stuff.

Actions #6

Updated by fdobrovo over 7 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to fdobrovo
Actions #7

Updated by jortel@redhat.com over 7 years ago

  • Sprint/Milestone changed from 27 to 28
Actions #9

Updated by fdobrovo over 7 years ago

  • Status changed from ASSIGNED to POST
Actions #10

Updated by mhrivnak over 7 years ago

  • Sprint/Milestone changed from 28 to 29
Actions #11

Updated by bmbouter over 7 years ago

I'm adding some checklist items to this.

Note that we had written a custom logger which on 3.0-dev is current housed at pulp.app.logs

I wrote this story originally to configure the logger at pulp.app.logs, but from the PR posted I think replacing our custom logger with the Django logger itself may be better. I would be very surprised if our custom logger was better than the Django logger.

See this related convo: https://github.com/pulp/pulp/pull/2862/files#r89887158

Actions #12

Updated by bmbouter over 7 years ago

  • Sprint/Milestone changed from 29 to 30

This is at POST but it needs more work so moving to Sprint 12.

Actions #13

Updated by mhrivnak about 7 years ago

  • Sprint/Milestone changed from 30 to 36

Added by fdobrovo almost 7 years ago

Revision 8bead7b1 | View on GitHub

Set celery logger to pulp logger

closes #2275 https://pulp.plan.io/issues/2275

Added by fdobrovo almost 7 years ago

Revision 8bead7b1 | View on GitHub

Set celery logger to pulp logger

closes #2275 https://pulp.plan.io/issues/2275

Actions #14

Updated by fdobrovo almost 7 years ago

  • Status changed from POST to MODIFIED
  • % Done changed from 0 to 100
Actions #15

Updated by bmbouter about 6 years ago

  • Sprint set to Sprint 17
Actions #16

Updated by bmbouter about 6 years ago

  • Sprint/Milestone deleted (36)
Actions #17

Updated by daviddavis almost 5 years ago

  • Sprint/Milestone set to 3.0.0
Actions #18

Updated by bmbouter almost 5 years ago

  • Tags deleted (Pulp 3)
Actions #19

Updated by bmbouter over 4 years ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE

Also available in: Atom PDF