Project

Profile

Help

Issue #2210

closed

The RPM rsync distributor accepts the remote_units_path in a non-obvious place

Added by Ichimonji10 over 7 years ago. Updated about 5 years ago.

Status:
CLOSED - WONTFIX
Priority:
Normal
Assignee:
-
Sprint/Milestone:
-
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
2.10.0
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Pulp 2
Sprint:
Quarter:

Description

When one is creating an RPM rsync distributor, one can pass a configuration dict like this:

{
    "distributor_id": "my_rpm_rsync_distributor",
    "distributor_type_id": "rpm_rsync_distributor",
    "distributor_config": {
        "remote": {
            "auth_type": "publickey",
            "ssh_user": "foo",
            "ssh_identity_file": "/home/user/.ssh/id_rsa",
            "host": "192.168.121.1",
            "root": "/home/foo/pulp_root_dir"
        },
        "predistributor_id": "yum_distributor"
    }
}

One of the optional configuration options is remote_units_path. It's a relative path that's joined with the root absolute path.

This option most naturally fits in the "remote" dict. However, Pulp currently expects it in the "distributor_config" dict. Please fix this by either:

  • Accepting the remote_units_path option in the remote dict, or
  • dropping the seemingly-spurious remote dict altogether.

It'd be pretty sweet if this fix could be added into Pulp before 2.10 heads out the door. Otherwise, we'll be left with a backwards-compatibility maintenance headache on our hands.

Also available in: Atom PDF