Issue #2111
closed
pulp streamer keep proxy for all repos
Status:
CLOSED - CURRENTRELEASE
Target Release - Nectar:
1.5.3
Description
after clients downloads rpms from a repository which has "on demand" download policy and also has "proxy" settings, all downloads from other repositories that don't have any proxy setting also go through proxy server until restarting pulp_streamer service!!
- Priority changed from Normal to High
- Severity changed from 2. Medium to 1. Low
- Triaged changed from No to Yes
- Sprint Candidate changed from No to Yes
- Status changed from NEW to ASSIGNED
- Assignee set to jcline@redhat.com
- Sprint/Milestone set to 24
- Sprint/Milestone changed from 24 to 25
- Status changed from ASSIGNED to POST
- Status changed from POST to MODIFIED
- % Done changed from 0 to 100
- Project changed from Pulp to Nectar
I can't find how to add a new target release, but I think the next release could be 1.5.3. I did add a new public method to the HTTPThreadedDownloader, but the behavior should be the same (sans bug).
- Target Release - Nectar set to 1.5.3
External deps need to be updated to include this in a future pulp release.
Ina kindly took care of adding the new build to the deps yesterday, I've associated the commit
- Platform Release set to 2.10.1
- Status changed from MODIFIED to 5
- Status changed from 5 to CLOSED - CURRENTRELEASE
- Sprint/Milestone deleted (
25)
Also available in: Atom
PDF
.
Change how Nectar configures requests to be thread-safe
Previously, Nectar set the configuration at a session level. This didn't cause problems because Nectar is only ever used to download with one set of settings. However, the pulp_streamer has to change the configuration on a request-by-request basis and it needs to use a session to pool connections. This leads to trouble when attempting to update the configuration since Nectar changes it for all requests rather than a specific one.
This patch instead adds a method to translate a Nectar configuration to a set of requests kwargs that work with the
requests.requestAPI. This allows the streamer to stash its session instance between instances of a Nectar HTTPThreadedDownloader without corruption.fixes #2111