Project

Profile

Help

Actions
Send by e-mail Copy link

Issue #1828

closed

pulp doesn't sync reference title correctly from errata

Added by jluza almost 7 years ago. Updated almost 4 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
High
Assignee:
jluza
Sprint/Milestone:
-
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
2.8.0
Platform Release:
2.8.3
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Easy Fix, Pulp 2
Sprint:
Quarter:

Description

if an errata's reference is in format:
<reference href="href" type="self" title="title"/>
pulp doesn't sync title at all.

Actions
Copy link
 #2

Updated by jluza almost 7 years ago

  • Status changed from NEW to POST
Actions
Copy link
 #3

Updated by bmbouter almost 7 years ago

  • Assignee set to jluza

jluza since you put in a PR I put you as the assignee. That field is used to track who did the work issue by issue.

Added by jluza almost 7 years ago

Revision 7bcfb290

  • fixed sync for reference title

https://pulp.plan.io/issues/1828 fixes #1828

Actions
Copy link
 #5

Updated by mhrivnak almost 7 years ago

  • Subject changed from pulp doesn't sync reference title correctly to pulp doesn't sync reference title correctly from errata
  • Description updated (diff)
  • Priority changed from Normal to High
  • Version set to 2.8.0
  • Platform Release set to 2.8.3
Actions
Copy link
 #6

Updated by mhrivnak almost 7 years ago

  • Triaged changed from No to Yes
Actions
Copy link
 #7

Updated by jluza almost 7 years ago

  • Triaged changed from Yes to No

Reproducer:

1. create rpm repo
2. sync from already existing repo that has at least one advisory with at least one reference with existing, non-empty title attribute
3. publish repo
4. published advisory in updateinfo will have title=null

Actions
Copy link
 #8

Updated by jluza almost 7 years ago

  • Triaged changed from No to Yes
Actions
Copy link
 #9

Updated by bmbouter almost 7 years ago

jluza, I looked for a repo that meets the criteria of step (2) in comment 7, but I could not find one. Can you identify the repo and errata inside of that repo more specifically which meets the critiera? I really want to review this, but I'm blocked finding the thing I should test it with.

Actions
Copy link
 #11

Updated by bmbouter almost 7 years ago

I reproduced the issue by syncing RHEL7.0 server and looking at the metadata entry for errata RHBA-2015:2255 it shows the snippet:

<reference href="https://rhn.redhat.com/errata/RHBA-2015-2255.html" id="" title="" type="self" />

After applying the fix from the linked PR that same line publishes with:

<reference href="https://rhn.redhat.com/errata/RHBA-2015-2255.html" id="" title="RHBA-2015:2255" type="self" />
Actions
Copy link
 #12

Updated by jluza almost 7 years ago

  • Status changed from POST to MODIFIED
  • % Done changed from 0 to 100
Actions
Copy link
 #13

Updated by semyers almost 7 years ago

  • Status changed from MODIFIED to 5
Actions
Copy link
 #14

Updated by semyers almost 7 years ago

  • Status changed from 5 to CLOSED - CURRENTRELEASE
Actions
Copy link
 #15

Updated by bmbouter almost 4 years ago

  • Tags Pulp 2 added
Actions
Send by e-mail Copy link

Also available in: Atom PDF