Issue #1766
closed
Pulp API is incompatible with Django 1.10
Status:
CLOSED - CURRENTRELEASE
Description
These appear in the system log on Fedora Rawhide:
pulp[1487]: py.warnings:WARNING: (1487-25344) /usr/lib/python2.7/site-packages/pulp/server/webservices/urls.py:260: RemovedInDjango110Warning: django.conf.urls.patterns() is deprecated and will be removed in Django 1.10. Update your urlpatterns to be a list of django.conf.urls.url() instances instead.
pulp[1487]: py.warnings:WARNING: (1487-25344) url(r'^v2/users/(?P<login>[^/]+)/$', users.UserResourceView.as_view(), name='user_resource')
pulp[1487]: py.warnings:WARNING: (1487-25344)
pulp[1488]: py.warnings:WARNING: (1488-69920) /usr/lib/python2.7/site-packages/pulp/server/webservices/urls.py:260: RemovedInDjango110Warning: django.conf.urls.patterns() is deprecated and will be removed in Django 1.10. Update your urlpatterns to be a list of django.conf.urls.url() instances instead.
pulp[1488]: py.warnings:WARNING: (1488-69920) url(r'^v2/users/(?P<login>[^/]+)/$', users.UserResourceView.as_view(), name='user_resource')
- Priority changed from Normal to High
- Severity changed from 2. Medium to 3. High
- Triaged changed from No to Yes
- Tags Easy Fix added
- Groomed changed from No to Yes
- Sprint Candidate changed from No to Yes
Looking at the roadmap[0], we will need to complete this next sprint if we don't want to break in Fedora Rawhide (and potentially 24/23, depending on how the package maintainer feels). Therefore I've flagged it to be considered next planning meeting
[0] https://code.djangoproject.com/wiki/Version1.10Roadmap
- Sprint Candidate changed from Yes to No
- Subject changed from Django URL API deprecation warnings in the log to Pulp API is incompatible with Django 1.10
- Sprint Candidate changed from No to Yes
asmacdo and I talked about this on IRC and I had suggested that we should defer until we lock onto Django 1.8, but I now realize that 1.10 will be added to rawhide, and possibly F24 and F23. This will break Pulp. As such, I'm re-titling it to show the severity more clearly. I'm also adding it back as a sprint candidate based on it's severity.
I propose that we write a super-simple compatibility layer which will have two implementations, the existing implementation and a new one. The new codepath will execute for Django 1.6+ and it will adhere to what the warnings recommend after we rewrite the urls.py file to use the new form. The existing codepath will execute for Django 1.5-.
A new task should be created also to remove this compatibility layer when we do lock onto Django 1.8 (the LTS).
- Sprint/Milestone set to 24
- Status changed from NEW to ASSIGNED
- Assignee set to amacdona@redhat.com
- Status changed from ASSIGNED to POST
- Status changed from POST to MODIFIED
- % Done changed from 0 to 100
- Platform Release set to 2.10.1
- Status changed from MODIFIED to 5
- Status changed from 5 to CLOSED - CURRENTRELEASE
- Sprint/Milestone deleted (
24)
Also available in: Atom
PDF
.
Update urls syntax for Django 1.10
Also adds a compat_urls.py file to support Django versions older than 1.6.
closes #1766