Project

Profile

Help

Issue #1709

Nectar 1.4.5 should be retagged/released as 1.5.0

Added by rbarlow about 5 years ago. Updated about 2 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
High
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version - Nectar:
Platform Release:
2.8.0
Target Release - Nectar:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Pulp 2
Sprint:
Quarter:

Description

It seems that we made an additive change to Nectar 1.4.5. During a Pulp sync with nectar < 1.4.5, I see this in the logs:

celery.worker.strategy:INFO: Received task: pulp.server.managers.repo.sync.sync[f700c1c6-4b5a-4b35-8357-db8eb703289e]
py.warnings:WARNING: (31271-34880) /usr/lib64/python2.7/site-packages/pymongo/topology.py:74: UserWarning: MongoClient opened before fork. Create MongoClient with connect=False, or create client after for
py.warnings:WARNING: (31271-34880)   "MongoClient opened before fork. Create MongoClient "
py.warnings:WARNING: (31271-34880)
celery.worker.strategy:INFO: Received task: pulp.server.async.tasks._release_resource[1c6df8d8-e4f8-4220-b78c-d3a0725afe0f]
celery.worker.job:INFO: Task pulp.server.async.tasks._queue_reserved_task[ef8f2e2c-a3f1-4699-913a-cbd62cdcea86] succeeded in 0.0972697869875s: None
: Exception AttributeError: "'DownloaderConfig' object has no attribute '_temp_files'" in <bound method DownloaderConfig.__del__ of <nectar.config.DownloaderConfig object at 0x7f82340eab50>> ignored
pulp.server.async.tasks:INFO: Task failed : [f700c1c6-4b5a-4b35-8357-db8eb703289e]
celery.worker.job:ERROR: (31002-34880) Task pulp.server.managers.repo.sync.sync[f700c1c6-4b5a-4b35-8357-db8eb703289e] raised unexpected: TypeError("__init__() got an unexpected keyword argument 'working_d
celery.worker.job:ERROR: (31002-34880) Traceback (most recent call last):
celery.worker.job:ERROR: (31002-34880)   File "/usr/lib/python2.7/site-packages/celery/app/trace.py", line 240, in trace_task
celery.worker.job:ERROR: (31002-34880)     R = retval = fun(*args, **kwargs)
celery.worker.job:ERROR: (31002-34880)   File "/home/vagrant/devel/pulp/server/pulp/server/async/tasks.py", line 473, in __call__
celery.worker.job:ERROR: (31002-34880)     return super(Task, self).__call__(*args, **kwargs)
celery.worker.job:ERROR: (31002-34880)   File "/home/vagrant/devel/pulp/server/pulp/server/async/tasks.py", line 103, in __call__
celery.worker.job:ERROR: (31002-34880)     return super(PulpTask, self).__call__(*args, **kwargs)
celery.worker.job:ERROR: (31002-34880)   File "/usr/lib/python2.7/site-packages/celery/app/trace.py", line 437, in __protected_call__
celery.worker.job:ERROR: (31002-34880)     return self.run(*args, **kwargs)
celery.worker.job:ERROR: (31002-34880)   File "/home/vagrant/devel/pulp/server/pulp/server/controllers/repository.py", line 757, in sync
celery.worker.job:ERROR: (31002-34880)     sync_report = sync_repo(transfer_repo, conduit, call_config)
celery.worker.job:ERROR: (31002-34880)   File "/home/vagrant/devel/pulp/server/pulp/server/async/tasks.py", line 658, in wrap_f
celery.worker.job:ERROR: (31002-34880)     return f(*args, **kwargs)
celery.worker.job:ERROR: (31002-34880)   File "/home/vagrant/devel/pulp_docker/plugins/pulp_docker/plugins/importers/importer.py", line 82, in sync_repo
celery.worker.job:ERROR: (31002-34880)     self.sync_step = sync.SyncStep(repo=repo, conduit=sync_conduit, config=config)
celery.worker.job:ERROR: (31002-34880)   File "/home/vagrant/devel/pulp_docker/plugins/pulp_docker/plugins/importers/sync.py", line 52, in __init__
celery.worker.job:ERROR: (31002-34880)     download_config = nectar_config.importer_config_to_nectar_config(config.flatten())
celery.worker.job:ERROR: (31002-34880)   File "/home/vagrant/devel/pulp/server/pulp/plugins/util/nectar_config.py", line 51, in importer_config_to_nectar_config
celery.worker.job:ERROR: (31002-34880)     download_config = DownloaderConfig(**download_config_kwargs)
celery.worker.job:ERROR: (31002-34880) TypeError: __init__() got an unexpected keyword argument 'working_dir'

Because this working_dir parameter is a new feature, it should be introduced as 1.5.0, not a z release.

This is important because downstream integrators can't know when they need to set version requirements on dependencies. For example, I did not think it was necessary to set nectar >= 1.4.5 in my spec file since 1.4.3 (the current version on my Fedora dev box) should be API sufficient.


Related issues

Related to Nectar - Issue #1210: ConnectionError - BadStatusLine during repo syncCLOSED - CURRENTRELEASE<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>

History

#1 Updated by ipanova@redhat.com about 5 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to ipanova@redhat.com

#2 Updated by mhrivnak about 5 years ago

  • Related to Issue #1210: ConnectionError - BadStatusLine during repo sync added

#3 Updated by mhrivnak about 5 years ago

  • Priority changed from Normal to High
  • Triaged changed from No to Yes

#4 Updated by ipanova@redhat.com about 5 years ago

  • Status changed from ASSIGNED to POST

#5 Updated by ipanova@redhat.com about 5 years ago

  • Status changed from POST to MODIFIED

#6 Updated by dkliban@redhat.com about 5 years ago

  • Status changed from MODIFIED to 5

#7 Updated by semyers almost 5 years ago

  • Status changed from 5 to CLOSED - CURRENTRELEASE
  • Platform Release set to 2.8.0

#8 Updated by bmbouter about 2 years ago

  • Tags Pulp 2 added

Please register to edit this issue

Also available in: Atom PDF