Project

Profile

Help

Issue #1694

closed

pulp-admin does not show error messages unless the user specifies the -v flag

Added by rbarlow over 8 years ago. Updated about 5 years ago.

Status:
CLOSED - WONTFIX
Priority:
Normal
Assignee:
-
Category:
-
Sprint/Milestone:
-
Start date:
Due date:
Estimated time:
Severity:
3. High
Version:
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Pulp 2
Sprint:
Quarter:

Description

The -v flag was supposed to enable debug messaging, but when it was implemented it also caused pulp-admin error messages (such as tracebacks) to be hidden from the user. This is not useful, particular when debugging intermittent problems. Any unhandled Exceptions should print the error message and traceback to the user because that is a crash bug and we need to fix it. The current behavior is not helpful and can make debugging intermittent problems much more difficult than they already are:

$ pulp-admin docker repo search image --repo-id 3742cb9b-ff6f-4f88-a271-f83ae8c88e52 --fields unit_id
An unexpected error has occurred. More information may be found using the -v
flag.

This output should happen without the -v:

$ pulp-admin -v docker repo search image --repo-id 3742cb9b-ff6f-4f88-a271-f83ae8c88e52 --fields unit_id
2016-02-18 18:43:54,947 - ERROR - Client-side exception occurred
Traceback (most recent call last):
  File "/home/vagrant/devel/pulp/client_lib/pulp/client/extensions/core.py", line 474, in run
    exit_code = Cli.run(self, args)
  File "/usr/lib/python2.7/site-packages/okaara/cli.py", line 974, in run
    exit_code = command_or_section.execute(self.prompt, remaining_args)
  File "/home/vagrant/devel/pulp/client_lib/pulp/client/extensions/extensions.py", line 210, in execute
    return self.method(*arg_list, **clean_kwargs)
  File "/home/vagrant/devel/pulp_docker/extensions_admin/pulp_docker/extensions/admin/images.py", line 106, in run
    image_id = image[u'metadata'][u'image_id']
KeyError: u'image_id'
An unexpected error has occurred. More information may be found using the -v
flag.

Additionally, it is silly that pulp-admin tells users to use the -v flag when they did use the -v flag.

The example problems I've supplied are from another bug I've filed, see #1693 if you are interested in that.

Also available in: Atom PDF