Actions
Issue #1692
closed
pulp-admin content sources refresh failing
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
2.8.0
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Pulp 2
Sprint:
Quarter:
Description
pulp-admin content sources refresh fails with "refresh() takes exactly 1 argument (2 given)
" error
[root@cloud-qe-14 ~]# pulp-admin content sources list
+----------------------------------------------------------------------+
Content Sources
+----------------------------------------------------------------------+
Base URL: http://download.devel.redhat.com/cds/prod/content/dist/rhel/rhui
/server/
Enabled: 1
Expires: 3d
Max Concurrent: 10
Max Speed: 1000
Name: Content World
Priority: 0
Source Id: content-world
SSL Validation: False
Type: yum
[root@cloud-qe-14 ~]# pulp-admin content sources refresh
+----------------------------------------------------------------------+
Refresh Content Sources
+----------------------------------------------------------------------+
This command may be exited via ctrl+c without affecting the request.
Refreshing content sources
[-]
Content World
... failed
refresh() takes exactly 1 argument (2 given)
Task Failed
refresh() takes exactly 1 argument (2 given)
[root@cloud-qe-14 ~]#
[root@cloud-qe-14 ~]#
[root@cloud-qe-14 ~]# pulp-admin content sources refresh --all
+----------------------------------------------------------------------+
Refresh Content Sources
+----------------------------------------------------------------------+
This command may be exited via ctrl+c without affecting the request.
Refreshing content sources
[-]
Content World
... failed
refresh() takes exactly 1 argument (2 given)
Task Failed
refresh() takes exactly 1 argument (2 given)
[root@cloud-qe-14 ~]# pulp-admin content sources refresh -s content-world
+----------------------------------------------------------------------+
Refresh Content Sources
+----------------------------------------------------------------------+
This command may be exited via ctrl+c without affecting the request.
Refreshing content sources
[-]
Content World
... failed
refresh() takes exactly 1 argument (2 given)
Task Failed
refresh() takes exactly 1 argument (2 given)
Feb 18 13:36:16 cloud-qe-14.idmqe.lab.eng.bos.redhat.com pulp[31965]: celery.worker.strategy:INFO: Received task: pulp.server.tasks.content.refresh_content_sources[e53923b6-4264-4514-9c0e-f78b33a094ef]
Feb 18 13:36:16 cloud-qe-14.idmqe.lab.eng.bos.redhat.com pulp[32190]: pulp.server.async.tasks:INFO: Task failed : [e53923b6-4264-4514-9c0e-f78b33a094ef]
Feb 18 13:36:16 cloud-qe-14.idmqe.lab.eng.bos.redhat.com pulp[31965]: celery.worker.job:ERROR: (31965-44096) Task pulp.server.tasks.content.refresh_content_sources[e53923b6-4264-4514-9c0e-f78b33a094ef] raised unexpected: TypeError('refresh() takes exactly 1 argument (2 given)',)
Feb 18 13:36:16 cloud-qe-14.idmqe.lab.eng.bos.redhat.com pulp[31965]: celery.worker.job:ERROR: (31965-44096) Traceback (most recent call last):
Feb 18 13:36:16 cloud-qe-14.idmqe.lab.eng.bos.redhat.com pulp[31965]: celery.worker.job:ERROR: (31965-44096) File "/usr/lib/python2.7/site-packages/celery/app/trace.py", line 240, in trace_task
Feb 18 13:36:16 cloud-qe-14.idmqe.lab.eng.bos.redhat.com pulp[31965]: celery.worker.job:ERROR: (31965-44096) R = retval = fun(*args, **kwargs)
Feb 18 13:36:16 cloud-qe-14.idmqe.lab.eng.bos.redhat.com pulp[31965]: celery.worker.job:ERROR: (31965-44096) File "/usr/lib/python2.7/site-packages/pulp/server/async/tasks.py", line 473, in __call__
Feb 18 13:36:16 cloud-qe-14.idmqe.lab.eng.bos.redhat.com pulp[31965]: celery.worker.job:ERROR: (31965-44096) return super(Task, self).__call__(*args, **kwargs)
Feb 18 13:36:16 cloud-qe-14.idmqe.lab.eng.bos.redhat.com pulp[31965]: celery.worker.job:ERROR: (31965-44096) File "/usr/lib/python2.7/site-packages/pulp/server/async/tasks.py", line 103, in __call__
Feb 18 13:36:16 cloud-qe-14.idmqe.lab.eng.bos.redhat.com pulp[31965]: celery.worker.job:ERROR: (31965-44096) return super(PulpTask, self).__call__(*args, **kwargs)
Feb 18 13:36:16 cloud-qe-14.idmqe.lab.eng.bos.redhat.com pulp[31965]: celery.worker.job:ERROR: (31965-44096) File "/usr/lib/python2.7/site-packages/celery/app/trace.py", line 437, in __protected_call__
Feb 18 13:36:16 cloud-qe-14.idmqe.lab.eng.bos.redhat.com pulp[31965]: celery.worker.job:ERROR: (31965-44096) return self.run(*args, **kwargs)
Feb 18 13:36:16 cloud-qe-14.idmqe.lab.eng.bos.redhat.com pulp[31965]: celery.worker.job:ERROR: (31965-44096) File "/usr/lib/python2.7/site-packages/pulp/server/controllers/content.py", line 91, in refresh_content_sources
Feb 18 13:36:16 cloud-qe-14.idmqe.lab.eng.bos.redhat.com pulp[31965]: celery.worker.job:ERROR: (31965-44096) step.process_lifecycle()
Feb 18 13:36:16 cloud-qe-14.idmqe.lab.eng.bos.redhat.com pulp[31965]: celery.worker.job:ERROR: (31965-44096) File "/usr/lib/python2.7/site-packages/pulp/plugins/util/publish_step.py", line 159, in process_lifecycle
Feb 18 13:36:16 cloud-qe-14.idmqe.lab.eng.bos.redhat.com pulp[31965]: celery.worker.job:ERROR: (31965-44096) step.process()
Feb 18 13:36:16 cloud-qe-14.idmqe.lab.eng.bos.redhat.com pulp[31965]: celery.worker.job:ERROR: (31965-44096) File "/usr/lib/python2.7/site-packages/pulp/plugins/util/publish_step.py", line 232, in process
Feb 18 13:36:16 cloud-qe-14.idmqe.lab.eng.bos.redhat.com pulp[31965]: celery.worker.job:ERROR: (31965-44096) self._process_block(item=item)
Feb 18 13:36:16 cloud-qe-14.idmqe.lab.eng.bos.redhat.com pulp[31965]: celery.worker.job:ERROR: (31965-44096) File "/usr/lib/python2.7/site-packages/pulp/plugins/util/publish_step.py", line 291, in _process_block
Feb 18 13:36:16 cloud-qe-14.idmqe.lab.eng.bos.redhat.com pulp[31965]: celery.worker.job:ERROR: (31965-44096) self.process_main(item=item)
Feb 18 13:36:16 cloud-qe-14.idmqe.lab.eng.bos.redhat.com pulp[31965]: celery.worker.job:ERROR: (31965-44096) File "/usr/lib/python2.7/site-packages/pulp/server/controllers/content.py", line 75, in process_main
Feb 18 13:36:16 cloud-qe-14.idmqe.lab.eng.bos.redhat.com pulp[31965]: celery.worker.job:ERROR: (31965-44096) report = item.refresh(e)[0]
Feb 18 13:36:16 cloud-qe-14.idmqe.lab.eng.bos.redhat.com pulp[31965]: celery.worker.job:ERROR: (31965-44096) TypeError: refresh() takes exactly 1 argument (2 given)
Actions
.
Fixed a simple argument mismatch bug in content sources code.
https://pulp.plan.io/issues/1692 The bug was introduced here: https://github.com/pulp/pulp/pull/2116/files#diff-4e345a77fb83e6a3dbcb29e9e12b7808R65 ... without a corresponding change to the calling code.
fixes #1692