Project

Profile

Help

Issue #1549

pulp_distribution.xml fails to conform to many of the XML recommendations and standards.

Added by jcline@redhat.com over 5 years ago. Updated over 2 years ago.

Status:
CLOSED - WONTFIX
Priority:
Normal
Assignee:
-
Sprint/Milestone:
-
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Pulp 2
Sprint:
Quarter:

Description

The XML specification states that an XML document should include an XML declaration of which version of XML is being used[0], as well as the character encoding used in the document. The XML document we use does not do this[1][2]. The prolog (for example "") should be the first line of the document.

XML documents should be in a namespace[3], but ours is not. A namespace should be something along the lines of "<something xmlns:"http://somehost/with/our/schema\>...\</something>". Since we don't do that, we don't include a schema with our document, either. The schema is located at https://github.com/pulp/pulp_rpm/blob/1ebbd75e8b076fd5d00c95b91c1c1ad26006ed52/plugins/usr/share/pulp-rpm/pulp_distribution.xsd

[0] https://www.w3.org/TR/REC-xml/#sec-prolog-dtd
[1] https://cdn.redhat.com/content/dist/rhel/server/7/7Server/x86_64/kickstart/PULP_DISTRIBUTION.xml
[2] https://github.com/pulp/pulp_rpm/blob/5872c026680e70979065504e8b9b610e7d4c8bb0/playpen/yum_distributor/generate_distribution_manifest.py
[3] https://www.w3.org/TR/xml-names/#sec-namespaces

History

#1 Updated by jortel@redhat.com over 5 years ago

  • Triaged changed from No to Yes

#2 Updated by bmbouter over 2 years ago

  • Status changed from NEW to CLOSED - WONTFIX

Pulp 2 is approaching maintenance mode, and this Pulp 2 ticket is not being actively worked on. As such, it is being closed as WONTFIX. Pulp 2 is still accepting contributions though, so if you want to contribute a fix for this ticket, please reopen or comment on it. If you don't have permissions to reopen this ticket, or you want to discuss an issue, please reach out via the developer mailing list.

#3 Updated by bmbouter over 2 years ago

  • Tags Pulp 2 added

Please register to edit this issue

Also available in: Atom PDF