Project

Profile

Help

Task #1400

closed

Develop a plan for how Pulp's master branch should determine when a worker was last seen

Added by rbarlow over 8 years ago. Updated almost 5 years ago.

Status:
CLOSED - WONTFIX
Priority:
Normal
Assignee:
-
Category:
-
Sprint/Milestone:
-
Start date:
Due date:
% Done:

0%

Estimated time:
Platform Release:
Groomed:
No
Sprint Candidate:
No
Tags:
Pulp 2
Sprint:
Quarter:

Description

In Issue #1380 it was determined that Pulp's workers were going missing due to some complicated interactions between Celery, Pulp, and Django. The quick fix done there was to use the Celery Event's "local_received" attribute instead of its "timestamp" attribute. There are two things different between these attributes, the first of which fixes the bug and the second of which changes Pulp's worker watcher behavior in a way that could be significant:

0) The "timestamp" attribute suffers from this Celery bug and the "local_received" attribute does not.
1) The "timestamp" attribute is created by the sender of the event at creation time. The "local_received" attribute is created by the receiver of the event at receipt time.

Pulp is currently using the "local_received" attribute to work around the bug in #1380. The purpose of this task is to have a place to discuss what Pulp should do in the future as there was some debate about this in #pulp on Freenode. I have described three options below, but please feel free to modify this description if you feel that there are more options that should be considered:

0) Wait for Celery to fix the bug and switch back to using the "timestamp" attribute.
1) Drop all usage of Celery provided times and calculate the time we received the event ourselves.
2) Do nothing and leave the code as is, using the "local_received" attribute.

Please use the comments to debate about the relative pros and cons of the above options.


Related issues

Related to Pulp - Issue #1380: Pulp workers are going missing continuallyCLOSED - CURRENTRELEASErbarlowActions

Also available in: Atom PDF