Pulp

We have discrepancy in some task state, this can lead to big confusion
.
For example we say to search for task state 'successful' but in reality it is finished:

$ pulp-admin -u admin -p admin  tasks list --help

Command: list
Description: lists tasks queued (waiting) or running on the server

Available Arguments:

  --all, -a   - if specified, all tasks in all states are shown
  --state, -s - comma-separated list of tasks states desired to be shown.
                Example: "running,waiting,canceled,successful,failed". Do not
                include spaces
[ipanova@ina pulp]$ pulp-admin -u admin -p admin  tasks list --state=successful

+----------------------------------------------------------------------+
                                 Tasks
+----------------------------------------------------------------------+

No tasks found

[ipanova@ina pulp]$ pulp-admin -u admin -p admin  tasks list --state=finished

+----------------------------------------------------------------------+
                                 Tasks
+----------------------------------------------------------------------+

Operations:  delete
Resources:   123 (repository)
State:       Successful
Start Time:  2015-06-09T13:45:18Z
Finish Time: 2015-06-09T13:45:18Z
Task Id:     68f82e64-096b-4cba-b6f1-4adc3694245a

[ipanova@ina pulp]$ curl -H "Accept: application/json" -H "WebFrameworkSwitch: django" -X GET -k -u admin:admin 'https://localhost/pulp/api/v2/tasks/68f82e64-096b-4cba-b6f1-4adc3694245a/'| python -m json.tool
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   687  100   672  100    15   2041     45 --:--:-- --:--:-- --:--:--  2042
{
    "_href": "/pulp/api/v2/tasks/68f82e64-096b-4cba-b6f1-4adc3694245a/",
    "_id": {
        "$oid": "5576edee3a9d37c231b56109"
    },
    "_ns": "task_status",
    "error": null,
    "exception": null,
    "finish_time": "2015-06-09T13:45:18Z",
    "id": "5576edee3a9d37c231b56109",
    "progress_report": {},
    "queue": "reserved_resource_worker-1@ina.usersys.redhat.com.dq",
    "result": null,
    "spawned_tasks": [],
    "start_time": "2015-06-09T13:45:18Z",
    "state": "finished",
    "tags": [
        "pulp:repository:123",
        "pulp:action:delete"
    ],
    "task_id": "68f82e64-096b-4cba-b6f1-4adc3694245a",
    "task_type": "pulp.server.tasks.repository.delete",
    "traceback": null,
    "worker_name": "reserved_resource_worker-1@ina.usersys.redhat.com"
}
[ipanova@ina pulp]$ 

Note: "state": "finished" vs State: Successful

Same issue for: error vs Failed

Note: The spelling in the state cannot be changed for backwards compat.