Project

Profile

Help

Issue #9535

closed

Sync optimization can result in invalid publications in combination with sync_policy=mirror_complete

Added by dalley about 3 years ago. Updated almost 3 years ago.

Status:
CLOSED - DUPLICATE
Priority:
High
Assignee:
Sprint/Milestone:
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
OS:
Triaged:
No
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:
Sprint 108
Quarter:

Description

Ticket moved to GitHub: "pulp/pulp_rpm/2316":https://github.com/pulp/pulp_rpm/issues/2316


If a primary repo changes and triggers a re-sync, but sub-repos do not change, those sub-repos will not be included in the publication created when metadata is mirrored. When a sync policy of mirror_complete is being used, sync optimization should only take place if none of the repositories (including sub-repos declared in the treeinfo metadata) have changed.

This is because the publication cannot put all of the files in their proper places without parsing the metadata. However, it might be possible to optimize this in the future to avoid actually sending content through the sync pipeline.

Other related issues to address simultaneously:

  • The sync optimization heuristic only takes the primary repo into account, so if sub-repos change without the primary repo having changed, Pulp will not notice
  • If a repo at a directory declared by the treeinfo metadata cannot be found, a warning is logged, rather than skipping it silently

Related issues

Copied to RPM Support - Backport #9536: Backport #9535 "Sync optimization can result in invalid publications in combination with sync_policy=mirror_complete" to 3.16.zCLOSED - CURRENTRELEASEdalley

Actions
Actions #1

Updated by dalley about 3 years ago

  • Copied to Backport #9536: Backport #9535 "Sync optimization can result in invalid publications in combination with sync_policy=mirror_complete" to 3.16.z added
Actions #2

Updated by dalley about 3 years ago

  • Sprint/Milestone set to 3.17.0

Added by dalley about 3 years ago

Revision ed923180 | View on GitHub

Fix sync optimization when sync_policy=mirror_complete

closes: #9535 https://pulp.plan.io/issues/9535

Actions #3

Updated by dalley about 3 years ago

  • Status changed from NEW to MODIFIED
Actions #4

Updated by fao89 almost 3 years ago

  • Description updated (diff)
  • Status changed from MODIFIED to CLOSED - DUPLICATE

Also available in: Atom PDF