Refactor #921
closed
Pulp importer config should use TypeError instead of ValueError where appropriate
Description
The Pulp importer config currently raises a 'ValueError' for some exceptions that should instead be 'TypeError'. For example, if the SSL CA certificate should be a string but is something else, Pulp will raise a ValueError.
It looks like there are eight methods in importer_config.py that need updating.
QE note: I don't think there is anything to test for this aside from no-break regression.
I would like to work on this issue.
@akasurde we want to support our new contributors. Here is some info on how to get started:
1. setup a pulp development environment. Almost all of developers use Vagrant using the instructions here[0].
2. Since this is a refactor, I think the best way to test Pulp using your patch would be using pulp smash[1] which is also integrated in the vagrant environment. Just make sure to clone pulp_smash next to your pulp and plugin checkouts before running vagrant up. At that point you can use psmash to run the integration tests.
3. You are welcome to post questions here or come join us in #pulp-dev on freenode. We would like to help you along with your contribution!
[0]: http://docs.pulpproject.org/dev-guide/contributing/dev_setup.html#vagrant
[1]: https://github.com/PulpQE/pulp-smash/
Sounds like a plan to me. Thanks I will update you, once I am done.
- Status changed from NEW to CLOSED - WONTFIX
Pulp 2 is approaching maintenance mode, and this Pulp 2 ticket is not being actively worked on. As such, it is being closed as WONTFIX. Pulp 2 is still accepting contributions though, so if you want to contribute a fix for this ticket, please reopen or comment on it. If you don't have permissions to reopen this ticket, or you want to discuss an issue, please reach out via the developer mailing list.
Also available in: Atom
PDF
.