Project

Profile

Help

Task #920

As a user, I can rely on Pulp server to compute the Puppet unit key in all cases

Added by bmbouter over 6 years ago. Updated over 2 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Start date:
Due date:
% Done:

100%

Estimated time:
Platform Release:
2.7.0
Groomed:
Yes
Sprint Candidate:
Yes
Tags:
Pulp 2
Sprint:
April 2015
Quarter:

Description

Currently the unit_key can be optionally submitted by the client. There aren't any use cases for Puppet content which require the client to need to specify the unit key when the metadata.json file contains everything needed for the server to compute this. The optional-ness has caused at least one bug (#890) and is overly complex. This story is an attempt to square up to that problem.

These deprecations need to be done as part of an X or Y release, not a Z.

Deliverables:

  • Consolidate the metadata.py module to eliminate many codepaths. The server logic will simplify. It should only look for the metadata.json in the "first folder". This logic is already in there from this PR [0], but all the extra .tar.gz extractions, special finding code, etc should be removed.
  • Stop the CLI from sending the unit_key when it calls /pulp/api/v2/repositories/<repo_id>/actions/import_upload/
  • Add a release note deprecating unit_key as a valid parameter to /pulp/api/v2/repositories/<repo_id>/actions/import_upload/
  • Add documentation to the Puppet docs that have the following:
  • The unit_key parameter to /pulp/api/v2/repositories/<repo_id>/actions/import_upload/ is deprecated and ignored
  • The server always computes the unit_key for uploaded Puppet modules based on the metadata (there is already a codepath for this today)
  • The format of the unit key the server computes
  • The requirements that Puppet modules adhere to the Puppet 3.6+ guidelines which require metadata and that metadata be expressed with metadata.json
  • The requirements that uploaded modules have exactly one Puppet module in them. Extra folders may cause unexpected behavior. Failure to find metadata.json will result in a failure.
  • A Note stating that even though puppet modules have to adhere to Puppet 3.6+ guidelines, these modules can still be installed using older puppet clients.
  • Update any tests and add test coverage for new code

[0]: https://github.com/pulp/pulp_puppet/pull/177/

Associated revisions

Revision 61be099f View on GitHub
Added by dkliban@redhat.com over 6 years ago

Removed generation of unit key based on file name of puppet module

This patch ensures that pulp-admin submits an empty string when making a request to upload a puppet module. The unit key is generated on the server based on the content of metadata.json found in the top level directory of a puppet module.

closes #920

History

#1 Updated by dkliban@redhat.com over 6 years ago

  • Description updated (diff)

#2 Updated by dkliban@redhat.com over 6 years ago

  • Description updated (diff)
  • Tags Groomed added

#3 Updated by dkliban@redhat.com over 6 years ago

  • Status changed from NEW to POST
  • Assignee set to dkliban@redhat.com

#4 Updated by dkliban@redhat.com over 6 years ago

  • Sprint/Milestone set to 15

#5 Updated by bmbouter over 6 years ago

  • Groomed set to Yes
  • Tags deleted (Groomed)

#6 Updated by bmbouter over 6 years ago

  • Sprint Candidate set to Yes
  • Tags deleted (Sprint Candidate)

#7 Updated by dkliban@redhat.com over 6 years ago

  • Status changed from POST to MODIFIED
  • % Done changed from 0 to 100

#8 Updated by rbarlow over 5 years ago

  • Project changed from Pulp to Puppet Support
  • Status changed from MODIFIED to 5
  • Platform Release set to 2.7.2

#9 Updated by semyers over 5 years ago

  • Status changed from 5 to CLOSED - CURRENTRELEASE
  • Platform Release changed from 2.7.2 to 2.7.0

#10 Updated by bmbouter over 3 years ago

  • Sprint set to April 2015

#11 Updated by bmbouter over 3 years ago

  • Sprint/Milestone deleted (15)

#12 Updated by bmbouter over 2 years ago

  • Tags Pulp 2 added

Please register to edit this issue

Also available in: Atom PDF