Project

Profile

Help

Issue #8543

closed

Range headers during blob upload should be inclusive

Added by ipanova@redhat.com over 3 years ago. Updated over 3 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Sprint/Milestone:
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Platform Release:
OS:
Triaged:
No
Groomed:
No
Sprint Candidate:
No
Tags:
GalaxyNG
Sprint:
Sprint 94
Quarter:

Description

Docker push of the same tag results in 2 different manifests. This happens because of the Range header not being inclusive on the blob upload response.

Before creating and sending manifest to the server, docker client asks the server whether blobs are being present by looking at the Range header issued by a PATCH requests during upload.

https://github.com/distribution/distribution/blob/6affafd1f030087d88f88841bf66a8abe2bf4d24/registry/client/blob_writer.go#L68 https://github.com/distribution/distribution/blob/6affafd1f030087d88f88841bf66a8abe2bf4d24/registry/handlers/blobupload.go#L321-L324

Actions #1

Updated by ipanova@redhat.com over 3 years ago

  • Assignee set to ipanova@redhat.com
  • Sprint set to Sprint 94
Actions #2

Updated by pulpbot over 3 years ago

  • Status changed from NEW to POST

Added by ipanova@redhat.com over 3 years ago

Revision 79478784 | View on GitHub

Updated Range header in the blob upload response so it is inclusive.

closes #8543

Added by ipanova@redhat.com over 3 years ago

Revision 79478784 | View on GitHub

Updated Range header in the blob upload response so it is inclusive.

closes #8543

Actions #3

Updated by ipanova@redhat.com over 3 years ago

  • Status changed from POST to MODIFIED
Actions #4

Updated by ipanova@redhat.com over 3 years ago

  • Sprint/Milestone set to 2.6.0
Actions #5

Updated by pulpbot over 3 years ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE

Also available in: Atom PDF