Issue #8321: check for the presence of trailing slash before assembling the url - Migration Plugin - Pulp

Actions

Send by e-mail Copy link

Issue #8321

closed

check for the presence of trailing slash before assembling the url

Added by ipanova@redhat.com about 3 years ago. Updated about 3 years ago.

Status:

CLOSED - CURRENTRELEASE

Priority:

Normal

Assignee:

ipanova@redhat.com

Sprint/Milestone:

Start date:

Due date:

Estimated time:

Severity:

2. Medium

Platform Release:

OS:

Triaged:

No

Groomed:

No

Sprint Candidate:

No

Tags:

Sprint:

Sprint 91

Quarter:

Description

Steps to reproduce in pulp2:

create a file (iso) repo in pulp2, with an importer pointing to https://fixtures.pulpproject.org/file (NOTE the lack of trailing space)
Sync the repository
Migrate the repository to pulp3
Check the created remote, you would expect: https://fixtures.pulpproject.org/file/PULP_MANIFEST, but in reality it will be https://fixtures.pulpproject.org/PULP_MANIFEST

place to fix https://github.com/pulp/pulp-2to3-migration/blob/master/pulp_2to3_migration/app/plugin/iso/repository.py#L37

Maybe also check for other occurrences where we use urljoin.

Actions

Send by e-mail Copy link

Also available in: Atom PDF