Project

Profile

Help

Issue #8321

closed

check for the presence of trailing slash before assembling the url

Added by ipanova@redhat.com almost 3 years ago. Updated almost 3 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Sprint/Milestone:
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Platform Release:
OS:
Triaged:
No
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:
Sprint 91
Quarter:

Description

Steps to reproduce in pulp2:

  1. create a file (iso) repo in pulp2, with an importer pointing to https://fixtures.pulpproject.org/file (NOTE the lack of trailing space)
  2. Sync the repository
  3. Migrate the repository to pulp3
  4. Check the created remote, you would expect: https://fixtures.pulpproject.org/file/PULP_MANIFEST, but in reality it will be https://fixtures.pulpproject.org/PULP_MANIFEST

place to fix https://github.com/pulp/pulp-2to3-migration/blob/master/pulp_2to3_migration/app/plugin/iso/repository.py#L37

Maybe also check for other occurrences where we use urljoin.

Actions #1

Updated by ipanova@redhat.com almost 3 years ago

  • Subject changed from check for the presence of trailing slash before assemling the url to check for the presence of trailing slash before assembling the url
  • Description updated (diff)
Actions #2

Updated by ipanova@redhat.com almost 3 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to ipanova@redhat.com
  • Sprint/Milestone set to 0.9.0
  • Sprint set to Sprint 91

Added by ipanova@redhat.com almost 3 years ago

Revision 1b5afe58 | View on GitHub

Ensure trailing slash is present when assembling the url.

closes #8321 https://pulp.plan.io/issues/8321

Added by ipanova@redhat.com almost 3 years ago

Revision 1b5afe58 | View on GitHub

Ensure trailing slash is present when assembling the url.

closes #8321 https://pulp.plan.io/issues/8321

Added by ipanova@redhat.com almost 3 years ago

Revision 1b5afe58 | View on GitHub

Ensure trailing slash is present when assembling the url.

closes #8321 https://pulp.plan.io/issues/8321

Actions #3

Updated by ipanova@redhat.com almost 3 years ago

  • Status changed from ASSIGNED to MODIFIED
Actions #4

Updated by pulpbot almost 3 years ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE

Also available in: Atom PDF