Project

Profile

Help

Issue #8315

Found some instances of bad i18n

Added by daviddavis 9 months ago. Updated 9 months ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
-
Category:
-
Sprint/Milestone:
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Easy Fix
Sprint:
Quarter:

Description

$ grep "_(f" **/*.py                                    
pulpcore/app/models/content.py:                _(f"Checksum algorithms {bad_keys} are forbidden for this Pulp instance.")
pulpcore/app/models/content.py:                _(f"Missing required checksum algorithms {missing_keys}.")
pulpcore/app/models/content.py:                        _(f"Checksum algorithm {algorithm} forbidden for this Pulp instance.")
pulpcore/app/models/content.py:                        _(f"Checksum algorithm {algorithm} forbidden for this Pulp instance.")
pulpcore/app/serializers/content.py:                _(f"Checksum algorithms {bad_algs} forbidden for this Pulp instance.")

Variables in f-strings are interpolated before being passed to gettext. We need to switch these to _("{}").format(var).


Related issues

Related to Pulp - Task #8316: Add check for bad usages of gettextCLOSED - CURRENTRELEASE

<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>

Associated revisions

Revision dd19a822 View on GitHub
Added by daviddavis 9 months ago

Fix bad i18n

fixes #8315

History

#1 Updated by daviddavis 9 months ago

  • Tags Easy Fix added

#2 Updated by daviddavis 9 months ago

  • Related to Task #8316: Add check for bad usages of gettext added

#3 Updated by daviddavis 9 months ago

  • Description updated (diff)

#4 Updated by daviddavis 9 months ago

  • Triaged changed from No to Yes

#5 Updated by pulpbot 9 months ago

  • Status changed from NEW to POST

#6 Updated by daviddavis 9 months ago

  • Status changed from POST to MODIFIED

#7 Updated by ipanova@redhat.com 9 months ago

  • Sprint/Milestone set to 3.11.0

#8 Updated by ipanova@redhat.com 9 months ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE

Please register to edit this issue

Also available in: Atom PDF