Actions
Issue #8299
closedschema conversion fails with 500
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Katello
Sprint:
Sprint 91
Quarter:
Description
repo used dotnet/dotnetcore-10-rhel7 from RH registry
$ curl -X GET "http://localhost:24817/v2/test2/manifests/latest" -L -i
HTTP/1.1 302 Found
Server: gunicorn/20.0.4
Date: Tue, 23 Feb 2021 17:32:13 GMT
Connection: close
Content-Type: text/html; charset=utf-8
Location: http://pulp3-source-fedora32.fluffy.example.com/pulp/container/test2/manifests/latest?validate_token=3275bec9474a1a7c2ef5939ff9f2cb1cebda8fec00c0b19226dc451209dfc014:1d866c8edddd0ba838edf99fb7801a147531d22853e5c8a8e667dab6f1a056cd
Allow: GET, PUT, HEAD, OPTIONS
Docker-Distribution-Api-Version: registry/2.0
X-Frame-Options: SAMEORIGIN
Content-Length: 0
Correlation-ID: 7e4b3bd2cf514a58a35218aff0cae63b
Access-Control-Expose-Headers: Correlation-ID
HTTP/1.1 500 Internal Server Error
Server: nginx/1.18.0
Date: Tue, 23 Feb 2021 17:32:14 GMT
Content-Type: text/plain; charset=utf-8
Content-Length: 55
Connection: keep-alive
500 Internal Server Error
Server got itself in trouble(pulp) [vagrant@pulp3-source-fedora32 _scripts]$ pjournal
-- Logs begin at Mon 2020-11-23 10:05:38 UTC. --
Feb 23 17:32:14 pulp3-source-fedora32.fluffy.example.com gunicorn[94459]: File "/home/vagrant/devel/pulp_container/pulp_container/app/schema_convert.py", line 70, in _convert_schema
Feb 23 17:32:14 pulp3-source-fedora32.fluffy.example.com gunicorn[94459]: converted_schema, schema_with_signature = converter.convert()
Feb 23 17:32:14 pulp3-source-fedora32.fluffy.example.com gunicorn[94459]: File "/home/vagrant/devel/pulp_container/pulp_container/app/schema_convert.py", line 120, in convert
Feb 23 17:32:14 pulp3-source-fedora32.fluffy.example.com gunicorn[94459]: self.compute_layers()
Feb 23 17:32:14 pulp3-source-fedora32.fluffy.example.com gunicorn[94459]: File "/home/vagrant/devel/pulp_container/pulp_container/app/schema_convert.py", line 153, in compute_layers
Feb 23 17:32:14 pulp3-source-fedora32.fluffy.example.com gunicorn[94459]: config = self._compute_v1_compatibility_config(
Feb 23 17:32:14 pulp3-source-fedora32.fluffy.example.com gunicorn[94459]: File "/home/vagrant/devel/pulp_container/pulp_container/app/schema_convert.py", line 198, in _compute_v1_compatibility_config
Feb 23 17:32:14 pulp3-source-fedora32.fluffy.example.com gunicorn[94459]: container_config=dict(Cmd=fs_layer.history["created_by"]),
Feb 23 17:32:14 pulp3-source-fedora32.fluffy.example.com gunicorn[94459]: KeyError: 'created_by'
Feb 23 17:32:14 pulp3-source-fedora32.fluffy.example.com gunicorn[94459]: 127.0.0.1 [23/Feb/2021:17:32:13 +0000] "GET /pulp/container/test2/manifests/latest?validate_token=3275bec9474a1a7c2ef5939ff9f2cb1cebda8fec00c0b19226dc451209dfc014:1d866c8edddd0ba838edf99fb7801a147531d22853e5c8a8e667dab6f1a056cd HTTP/1.0" 500 225 "-" "curl/7.69.1"
Updated by lmjachky over 3 years ago
- Status changed from NEW to ASSIGNED
- Assignee set to lmjachky
- Sprint set to Sprint 91
Updated by pulpbot over 3 years ago
- Status changed from ASSIGNED to POST
Added by Lubos Mjachky over 3 years ago
Added by Lubos Mjachky over 3 years ago
Revision c9bca591 | View on GitHub
Return an empty string when the key does not exist
In this commit, there was also fixed the output format of the field Cmd
.
In the past, we had been returning: "container_config":{"Cmd":"/bin/sh -c #(nop) ADD file:ab8940a9b8a62d2f2c4634bf5e63a87ea73736bd0313412e41be2351c4fbdf53 in / "}.
As of now, the command is wrapped by a list: "container_config":{"Cmd":["/bin/sh -c #(nop) ADD file:ab8940a9b8a62d2f2c4634bf5e63a87ea73736bd0313412e41be2351c4fbdf53 in / "]}
closes #8299
Updated by Anonymous over 3 years ago
- Status changed from POST to MODIFIED
Applied in changeset c9bca5911004145c8406f373232a536858888bb4.
Updated by pulpbot over 3 years ago
- Status changed from MODIFIED to CLOSED - CURRENTRELEASE
Actions
Return an empty string when the key does not exist
In this commit, there was also fixed the output format of the field
Cmd
.In the past, we had been returning: "container_config":{"Cmd":"/bin/sh -c #(nop) ADD file:ab8940a9b8a62d2f2c4634bf5e63a87ea73736bd0313412e41be2351c4fbdf53 in / "}.
As of now, the command is wrapped by a list: "container_config":{"Cmd":["/bin/sh -c #(nop) ADD file:ab8940a9b8a62d2f2c4634bf5e63a87ea73736bd0313412e41be2351c4fbdf53 in / "]}
closes #8299