Issue #815: publishing with puppet_distributor fails - Puppet Support - Pulp

Actions

Send by e-mail Copy link

Issue #815

closed

publishing with puppet_distributor fails

Added by dkliban@redhat.com over 9 years ago. Updated over 5 years ago.

Status:

CLOSED - CURRENTRELEASE

Priority:

Normal

Assignee:

dkliban@redhat.com

Start date:

Due date:

Estimated time:

Severity:

2. Medium

Version:

Master

Platform Release:

2.7.0

OS:

Triaged:

Yes

Groomed:

Sprint Candidate:

Tags:

Easy Fix, Pulp 2

Sprint:

Quarter:

Description

I uploaded https://forgeapi.puppetlabs.com/v3/files/puppetlabs-apache-1.4.0.tar.gz to my puppet repo. Then I ran following command:

pulp-admin puppet repo  publish run --repo-id myforge2

This resulted in

Mar 25 16:04:02 localhost pulp[20267]: pulp_puppet.plugins.distributors.publish:INFO: Beginning publish for repository <myforge2>
Mar 25 16:04:02 localhost pulp[20267]: pulp_puppet.plugins.distributors.publish:INFO: Initializing build directory for repository <myforge2>
Mar 25 16:04:02 localhost pulp[20267]: pulp_puppet.plugins.distributors.publish:INFO: Creating symlinks for modules in repository <myforge2>
Mar 25 16:04:02 localhost pulp[20267]: pulp_puppet.plugins.distributors.publish:INFO: Generating metadata for repository <myforge2>
Mar 25 16:04:02 localhost pulp[20267]: pulp_puppet.plugins.distributors.publish:ERROR: (20267-61632) Exception during metadata generation step for repository <myforge2>
Mar 25 16:04:02 localhost pulp[20267]: pulp_puppet.plugins.distributors.publish:ERROR: (20267-61632) Traceback (most recent call last):
Mar 25 16:04:02 localhost pulp[20267]: pulp_puppet.plugins.distributors.publish:ERROR: (20267-61632)   File "/home/dkliban/src/pulp_puppet/pulp_puppet_plugins/pulp_puppet/plugins/distributors/publish.py", line 138, in _metadata_step
Mar 25 16:04:02 localhost pulp[20267]: pulp_puppet.plugins.distributors.publish:ERROR: (20267-61632)     self._generate_dependency_data(modules)
Mar 25 16:04:02 localhost pulp[20267]: pulp_puppet.plugins.distributors.publish:ERROR: (20267-61632)   File "/home/dkliban/src/pulp_puppet/pulp_puppet_plugins/pulp_puppet/plugins/distributors/publish.py", line 319, in _generate_dependency_data
Mar 25 16:04:02 localhost pulp[20267]: pulp_puppet.plugins.distributors.publish:ERROR: (20267-61632)     if key in db:
Mar 25 16:04:02 localhost pulp[20267]: pulp_puppet.plugins.distributors.publish:ERROR: (20267-61632) TypeError: gdbm key must be string, not unicode
Mar 25 16:04:02 localhost pulp[20267]: pulp.server.managers.repo.publish:INFO: publish failed for repo [myforge2] with distributor ID [puppet_distributor]

Actions

Copy link

Updated by dkliban@redhat.com over 9 years ago

The problem was introduced here https://github.com/pulp/pulp_puppet/commit/6e3ea608268541b0b9e0367dcefc773fb542c016#diff-c4e837f262081e33d82d042221db3b20L321

I will revert the change and add a flag to tell flake8 to ignore this line. This object is not a dictionary, which is what flake8 assumes it is. As a result flake8 suggests that has_key() is deprecated.

Actions

Copy link