Project

Profile

Help

Issue #815

publishing with puppet_distributor fails

Added by dkliban@redhat.com over 6 years ago. Updated over 2 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Master
Platform Release:
2.7.0
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Easy Fix, Pulp 2
Sprint:
Quarter:

Description

I uploaded https://forgeapi.puppetlabs.com/v3/files/puppetlabs-apache-1.4.0.tar.gz to my puppet repo. Then I ran following command:

pulp-admin puppet repo  publish run --repo-id myforge2

This resulted in

Mar 25 16:04:02 localhost pulp[20267]: pulp_puppet.plugins.distributors.publish:INFO: Beginning publish for repository <myforge2>
Mar 25 16:04:02 localhost pulp[20267]: pulp_puppet.plugins.distributors.publish:INFO: Initializing build directory for repository <myforge2>
Mar 25 16:04:02 localhost pulp[20267]: pulp_puppet.plugins.distributors.publish:INFO: Creating symlinks for modules in repository <myforge2>
Mar 25 16:04:02 localhost pulp[20267]: pulp_puppet.plugins.distributors.publish:INFO: Generating metadata for repository <myforge2>
Mar 25 16:04:02 localhost pulp[20267]: pulp_puppet.plugins.distributors.publish:ERROR: (20267-61632) Exception during metadata generation step for repository <myforge2>
Mar 25 16:04:02 localhost pulp[20267]: pulp_puppet.plugins.distributors.publish:ERROR: (20267-61632) Traceback (most recent call last):
Mar 25 16:04:02 localhost pulp[20267]: pulp_puppet.plugins.distributors.publish:ERROR: (20267-61632)   File "/home/dkliban/src/pulp_puppet/pulp_puppet_plugins/pulp_puppet/plugins/distributors/publish.py", line 138, in _metadata_step
Mar 25 16:04:02 localhost pulp[20267]: pulp_puppet.plugins.distributors.publish:ERROR: (20267-61632)     self._generate_dependency_data(modules)
Mar 25 16:04:02 localhost pulp[20267]: pulp_puppet.plugins.distributors.publish:ERROR: (20267-61632)   File "/home/dkliban/src/pulp_puppet/pulp_puppet_plugins/pulp_puppet/plugins/distributors/publish.py", line 319, in _generate_dependency_data
Mar 25 16:04:02 localhost pulp[20267]: pulp_puppet.plugins.distributors.publish:ERROR: (20267-61632)     if key in db:
Mar 25 16:04:02 localhost pulp[20267]: pulp_puppet.plugins.distributors.publish:ERROR: (20267-61632) TypeError: gdbm key must be string, not unicode
Mar 25 16:04:02 localhost pulp[20267]: pulp.server.managers.repo.publish:INFO: publish failed for repo [myforge2] with distributor ID [puppet_distributor]

Associated revisions

Revision 55be4f38 View on GitHub
Added by dkliban@redhat.com over 6 years ago

Fixes #815 - db is not a dict as flake8 assumed

Revision 7504b90d View on GitHub
Added by dkliban@redhat.com over 6 years ago

Merge pull request #173 from dkliban/815

Fixes #815 - db is not a dict as flake8 assumed

History

#1 Updated by dkliban@redhat.com over 6 years ago

The problem was introduced here https://github.com/pulp/pulp_puppet/commit/6e3ea608268541b0b9e0367dcefc773fb542c016#diff-c4e837f262081e33d82d042221db3b20L321

I will revert the change and add a flag to tell flake8 to ignore this line. This object is not a dictionary, which is what flake8 assumes it is. As a result flake8 suggests that has_key() is deprecated.

#2 Updated by dkliban@redhat.com over 6 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to dkliban@redhat.com
  • Triaged changed from No to Yes
  • Platform Release set to master
  • Tags Easy Fix added

#3 Updated by dkliban@redhat.com over 6 years ago

  • Status changed from ASSIGNED to MODIFIED
  • % Done changed from 0 to 100

#5 Updated by rbarlow over 6 years ago

  • Platform Release changed from master to 2.7.0

#6 Updated by dkliban@redhat.com over 6 years ago

  • Status changed from MODIFIED to 5

#7 Updated by dkliban@redhat.com almost 6 years ago

  • Status changed from 5 to CLOSED - CURRENTRELEASE

#8 Updated by bmbouter over 2 years ago

  • Tags Pulp 2 added

Please register to edit this issue

Also available in: Atom PDF