Issue #7382: pulp_installer pulp_install_plugins source_dir of VCS type not fully supported - Pulp

Actions

Send by e-mail Copy link

Issue #7382

closed

pulp_installer pulp_install_plugins source_dir of VCS type not fully supported

Added by cmeyers over 4 years ago. Updated about 4 years ago.

Status:

CLOSED - CURRENTRELEASE

Priority:

Normal

Assignee:

Category:

Installer - Moved to GitHub issues

Sprint/Milestone:

3.8.0

Start date:

Due date:

Estimated time:

Severity:

2. Medium

Version:

Platform Release:

OS:

Triaged:

Groomed:

Sprint Candidate:

Tags:

Sprint:

Quarter:

Description

- name: Create requirements.in file to check pulpcore/plugin compatibility
  template:
    src: templates/requirements.in.j2
    dest: "{{ pulp_install_dir }}/requirements.in"

The pip-compile step shortly after this task in pulp_common fails to use VCS information.

pulp_install_plugins:
  pulp-container:
    source_dir: "git+https://github.com/{{ pulp_container_fork }}/pulp_container@{{ pulp_container_refspec }}#egg=pulp-container"
  pulp-ansible:
    source_dir: "git+https://github.com/{{ pulp_ansible_fork }}/pulp_ansible@{{ pulp_ansible_refspec }}#egg=pulp-ansible"
  galaxy-ng:
    source_dir: "git+https://github.com/{{ galaxy_ng_fork }}/galaxy_ng@{{ galaxy_ng_refspec }}#egg=galaxy-ng"

Added by Chris Meyers over 4 years ago

Revision 85bd023d | View on GitHub

support per pulp_install_plugins source_dir vcs

Problem: The requirements.in file that pip-compile consumes only includes the package name and not the source_dir

Solution: Per pulp_install_plugins source_dir entries that are vcs are added to the pip-compile requirements.in so that the pip-compile line will have all the information available to decide if requirements and dependencies are met.

fixes: #7382 https://pulp.plan.io/issues/7382