Project

Profile

Help

Issue #6954

closed

Pulp should provide a User Agent on all requests it makes

Added by dalley almost 4 years ago. Updated almost 4 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
Category:
-
Sprint/Milestone:
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:
Sprint 75
Quarter:

Description

Many upstream repositories such as PyPI [0] request that all mirroring tools provide a User Agent to identify themselves. Pulp does not currently do this.

Here is an example of the User Agent that Bandersnatch provides:

'bandersnatch/4.1.0.dev0 (cpython 3.8.3-final0, Linux x86_64) (aiohttp 3.6.2)'

And the code that produces it:

https://github.com/pypa/bandersnatch/blob/1393dbc57a3dd67afd4c3b588ddfd4f8bc1e0de0/src/bandersnatch/utils.py#L23-L31

https://github.com/pypa/bandersnatch/blob/d816a853b57b1eb38643c4d32a371e67d5fc55a3/src/bandersnatch/master.py#L50

[0] https://www.python.org/dev/peps/pep-0381/#user-agent-request-header

Actions #1

Updated by dalley almost 4 years ago

  • Description updated (diff)
Actions #2

Updated by dalley almost 4 years ago

  • Description updated (diff)
Actions #3

Updated by dalley almost 4 years ago

  • Description updated (diff)
Actions #4

Updated by dalley almost 4 years ago

  • Sprint set to Sprint 75
Actions #5

Updated by dalley almost 4 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to dalley
  • Triaged changed from No to Yes
Actions #6

Updated by pulpbot almost 4 years ago

  • Status changed from ASSIGNED to POST

Added by dalley almost 4 years ago

Revision 82136ae1 | View on GitHub

Add a user-agent string to all of Pulp's aiohttp requests

closes: #6954 https://pulp.plan.io/issues/6954

Actions #7

Updated by dalley almost 4 years ago

  • Status changed from POST to MODIFIED
Actions #8

Updated by fao89 almost 4 years ago

  • Sprint/Milestone set to 3.5.0
Actions #9

Updated by pulpbot almost 4 years ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE

Also available in: Atom PDF