Project

Profile

Help

Issue #6835

closed

.travis/release.py in pulpcore creates the wrong version for the final .dev version commit

Added by dkliban@redhat.com almost 4 years ago. Updated almost 4 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
-
Category:
-
Sprint/Milestone:
-
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
OS:
Triaged:
No
Groomed:
No
Sprint Candidate:
No
Tags:
Documentation
Sprint:
Quarter:

Description

Noticed that when I was releasing 3.4.0 and ran

python3 .travis/release.py major

The final version was set to 4.0.0.dev when it should have been 3.5.0.dev

Actions #1

Updated by dkliban@redhat.com almost 4 years ago

  • Description updated (diff)
Actions #2

Updated by fao89 almost 4 years ago

  • Tags Documentation added

How can we document better this script?

Currently it depends on:

bump2version
gitpython

it has a help from argparse:

❯ python .travis/release.py --help
usage: release.py [-h] [--lower LOWER] [--upper UPPER] release_part

Start the release process.

Example:
    setup.py on plugin before script:
        version="2.0.dev"
        requirements = ["pulpcore>=3.4"]

    $ python .travis/realease.py minor 4.0 4.1

    setup.py on plugin after script:
        version="2.1.dev"
        requirements = ["pulpcore>=4.0,<4.1"]

positional arguments:
  release_part   Whether the release should be major, minor or patch.

optional arguments:
  -h, --help     show this help message and exit
  --lower LOWER  Lower bound of pulpcore requirement.
  --upper UPPER  Upper bound of pulpcore requirement.

Release: x.y.z = major, minor, patch

pulpcore example:

python .travis/release.py minor

pulp_file example:

python .travis/release.py minor --lower 3.3.5 --upper 3.4.0

lower and upper are for pulpcore requirement, from the previous example, it should return:

pulpcore>=3.3.5,<3.4.0
Actions #3

Updated by fao89 almost 4 years ago

  • Triaged changed from No to Yes
  • Sprint set to Sprint 74

Use the wiki to document it

Actions #4

Updated by fao89 almost 4 years ago

  • Status changed from NEW to CLOSED - CURRENTRELEASE
  • Triaged changed from Yes to No
  • Sprint deleted (Sprint 74)

Updated the release wiki

Also available in: Atom PDF