Project

Profile

Help

Actions
Send by e-mail Copy link

Story #67

closed

As a developer, nectar's threaded downloader can process session.proxies auth information correctly without having to update session.auth manually.

Added by Anonymous over 9 years ago. Updated over 2 years ago.

Status:
CLOSED - WONTFIX
Priority:
Normal
Assignee:
-
Start date:
Due date:
% Done:

0%

Estimated time:
Platform Release:
Target Release - Nectar:
Groomed:
No
Sprint Candidate:
No
Tags:
Pulp 2
Sprint:
Quarter:

Description

We have a little bit of code duplication and redundancy in the _add_proxy function of threaded downloader. This was required as python-requests 2.0.0 had a bug which was not passing the proxy authentication information correctly. Now that we have moved to 2.2.1, it seems to have certain bugfixes, which might let us remove this extra code and rely on session.proxies for auth information completely. We do need to make sure that this handles situations with proxy with and without auth, with and without ssl etc. properly.

Actions
Send by e-mail Copy link

Also available in: Atom PDF