Project

Profile

Help

Actions
Send by e-mail Copy link

Task #5786

closed

Remove "missing workers" from Status API

Added by bmbouter almost 5 years ago. Updated almost 5 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
bmbouter
Category:
-
Sprint/Milestone:
3.0.0
Start date:
Due date:
% Done:

100%

Estimated time:
Platform Release:
Groomed:
Yes
Sprint Candidate:
No
Tags:
Sprint:
Sprint 62
Quarter:

Description

Problem

Environments that have random worker names chosen each time a worker starts, e.g. k8s/openshift, will accumulate a "missing worker" each time a worker starts. This part of the API made sense when the workers always used the same names.

Solution

Remove the "missing workers" from the Task API

Actions
Copy link
 #1

Updated by daviddavis almost 5 years ago

  • Tracker changed from Issue to Task
  • % Done set to 0
  • Groomed changed from No to Yes
  • Sprint set to Sprint 62
Actions
Copy link
 #2

Updated by bmbouter almost 5 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to bmbouter
Actions
Copy link
 #3

Updated by bmbouter almost 5 years ago

Also should we?

online_worker -> workers
online_content_apps -> content_apps

Actions
Copy link
 #4

Updated by daviddavis almost 5 years ago

That sounds fine to me.

Actions
Copy link
 #5

Updated by bmbouter almost 5 years ago

daviddavis wrote:

That sounds fine to me.

I made the change and decided to revert it. Having online_ does make it really clear these are the "online" workers.

Actions
Copy link
 #6

Updated by bmbouter almost 5 years ago

  • Status changed from ASSIGNED to POST

Added by bmbouter almost 5 years ago

Revision bf8794ac | View on GitHub

Remove "missing_workers" from Status API

Having "missing_workers" did not work well when worker names are unique each time. It accumulated an endless number of worker names.

https://pulp.plan.io/issues/5786 closes #5786

Actions
Copy link
 #7

Updated by bmbouter almost 5 years ago

  • Status changed from POST to MODIFIED
  • % Done changed from 0 to 100

Added by bmbouter almost 5 years ago

Revision c0fcdb7c | View on GitHub

Remove "missing_workers" from Status API

Having "missing_workers" did not work well when worker names are unique each time. It accumulated an endless number of worker names.

https://pulp.plan.io/issues/5786 closes #5786

(cherry picked from commit bf8794ac47f34d0cb487b66ffc41bde496fad761)

Actions
Copy link
 #8

Updated by bmbouter almost 5 years ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE
Actions
Send by e-mail Copy link

Also available in: Atom PDF