Issue #5078: Including a PR in a Travis build fails with 'pushd: not found' - Pulp

Actions

Send by e-mail Copy link

Issue #5078

closed

Including a PR in a Travis build fails with 'pushd: not found'

Added by daviddavis over 5 years ago. Updated almost 5 years ago.

Status:

CLOSED - CURRENTRELEASE

Priority:

High

Assignee:

Category:

Sprint/Milestone:

3.0.0

Start date:

Due date:

Estimated time:

Severity:

2. Medium

Version:

Platform Release:

OS:

Triaged:

Yes

Groomed:

Sprint Candidate:

Tags:

Plugin Template

Sprint:

Sprint 55

Quarter:

Description

Example: https://travis-ci.org/pulp/pulp_file/jobs/553829203#L505-L508

Error:

.travis/before_install.sh: 49: .travis/before_install.sh: pushd: not found
fatal: not a git repository (or any of the parent directories): .git
fatal: not a git repository (or any of the parent directories): .git
.travis/before_install.sh: 52: .travis/before_install.sh: popd: not found

We think the problem is that Travis is using Ubuntu which has dash and push/popd are bash extensions.

Actions

Copy link

Updated by daviddavis over 5 years ago

Tags Plugin Template added

Actions

Copy link

Updated by amacdona@redhat.com over 5 years ago

Priority changed from Normal to High
Triaged changed from No to Yes
Sprint set to Sprint 55

Added by gmbnomis over 5 years ago

Revision 06541f8c | View on GitHub

Improve before_install.sh

Use bash and the more secure set -mveuo pipefail (as in other scripts)
Use shallow clones and shallow fetch to speed up the CI run (Especially pulpcore takes a long time to clone completely. We don't need any history when building in the CI.)
get rid of pushd/popd (bashism that is not needed here)

https://pulp.plan.io/issues/5078 fixes #5078

Actions

Copy link