Task #5060: Rework 4 existing container images into 1 image with 4 different entrypoints - Pulp

Actions

Send by e-mail Copy link

Task #5060

closed

Task #5069: Build pulp 3 containers

Rework 4 existing container images into 1 image with 4 different entrypoints

Added by mdepaulo@redhat.com over 5 years ago. Updated over 5 years ago.

Status:

CLOSED - COMPLETE

Priority:

Normal

Assignee:

mdepaulo@redhat.com

Category:

Sprint/Milestone:

Start date:

Due date:

% Done:

100%

Estimated time:

Platform Release:

Groomed:

Sprint Candidate:

Tags:

Sprint:

Sprint 55

Quarter:

Description

In order to avoid container image layering sprawl, especially when building the container images with different sets of plugins, we need to go from 4 container images:
pulp-api
pulp-content (based on pulp-api)
pulp-worker (based on pulp-api)
pulp-resource-manager (based on pulp-api)

To just one image.
(Name will depend on whether plugins are installed, and which ones).

It will be the responsbility of the operator/script to call the 4 different entrypoints, 1 for each service/container.

The image will need to provide commands (with stable paths) that encapsulate all that I need to be done for each service/container. Right now it may only be a command with a symlink, but later on it may be a script. For example:
/usr/bin/entrypoint-pulp-api
/usr/bin/entrypoint-pulp-content
/usr/bin/entrypoint-pulp-resource-manager
/usr/bin/entrypoint-pulp-worker

Actions

Copy link

Updated by daviddavis over 5 years ago

Parent issue changed from #5004 to #5069

Actions

Copy link

Updated by mdepaulo@redhat.com over 5 years ago

% Done changed from 0 to 50

I reworked them, but still need to figure out naming conventions and stable interfaces for CMDs/ENTRYPOINTs.

https://github.com/mikedep333/pulpcore/tree/1-image-to-rule-them-all

Actions

Copy link

Updated by mdepaulo@redhat.com over 5 years ago

Status Update:

I've done more research, including discussion with #podman on Freenode.

I've decided to keep the current common entrypoint in the Dockerfile, and use the commands that we're currently using, but with the /usr/bin/ dropped:
pulp-api
pulp-content
pulp-resource-manager
pulp-worker

These are the same as the systemd service names.

The entrypoint can always take special steps based on the command passed to it.

Alternatives considered:
1. Use a label like ROLE=pulp-api (This has the disadvantage of being less straightforward than specifying the command. The command is still like a role.)
2. Use a podman runlabel (No Docker support, and would only work for a single container/process/service anyway.)
3. `podman play kube` (No docker support, and the stable command API would be valuable for users that never see updated kube .yml file, but run the "latest" image. Still, I might use this instead of a script to launch all 4 containers.)
4. `docker compose` (Same as above, except Docker proprietary.)
5. All processes in 1 container - Not how containers are supposed to be used, and prevents auto-scaling done by K8s.

TODO: Update pulp-operator for this

Actions

Copy link