Project

Profile

Help

Actions
Send by e-mail Copy link

Issue #5056

closed

Required PR for pulp_file doesn't work

Added by amacdona@redhat.com over 5 years ago. Updated almost 5 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
amacdona@redhat.com
Category:
-
Sprint/Milestone:
3.0.0
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
OS:
Triaged:
No
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:
Sprint 55
Quarter:

Description

The pulp_file required PR logic happens in the pre_before_install file.
https://github.com/pulp/pulpcore/blob/master/.travis/pre_before_install.sh#L1

However, this uses an environment variable $COMMIT_MSG that is set after pre_before_install is executed.
https://github.com/pulp/pulpcore/blob/master/.travis/before_install.sh#L11

Added by amacdona@redhat.com over 5 years ago

Revision 08e3e21c | View on GitHub

make commit msg available to pre-before-install

https://pulp.plan.io/issues/5056 fixes #5056

Actions
Copy link
 #1

Updated by amacdona@redhat.com over 5 years ago

  • Status changed from NEW to POST
  • Assignee set to amacdona@redhat.com
Actions
Copy link
 #2

Updated by amacdona@redhat.com over 5 years ago

  • Status changed from POST to MODIFIED

Added by amacdona@redhat.com over 5 years ago

Revision d21b1546 | View on GitHub

Use the template to fix Required PR logic

https://pulp.plan.io/issues/5056 re #5056

Actions
Copy link
 #3

Updated by amacdona@redhat.com over 5 years ago

  • Sprint set to Sprint 55
Actions
Copy link
 #4

Updated by bmbouter almost 5 years ago

  • Sprint/Milestone set to 3.0.0
Actions
Copy link
 #5

Updated by bmbouter almost 5 years ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE
Actions
Send by e-mail Copy link

Also available in: Atom PDF