Project

Profile

Help

Actions
Send by e-mail Copy link

Task #5010

closed

Travis fails when PRs are rebased and merged

Added by daviddavis over 5 years ago. Updated about 5 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
daviddavis
Category:
-
Sprint/Milestone:
3.0.0
Start date:
Due date:
% Done:

100%

Estimated time:
Platform Release:
Groomed:
No
Sprint Candidate:
No
Tags:
Plugin Template
Sprint:
Quarter:

Description

Failing Travis:

https://travis-ci.com/pulp/pulpcore/jobs/210048379#L904-L908

The cause is that sometimes HEAD^2 is undefined. Try this in pulpcore and you'll get the same problem:

git checkout 2ccdc7dc0135a62d37854caecf664232f9303dfe
git show HEAD^2 -s

We probably shouldn't rely on HEAD^2. Rather, it looks like Travis has a TRAVIS_COMMIT_MESSAGE we could maybe use.

Actions
Copy link
 #1

Updated by amacdona@redhat.com over 5 years ago

  • Tracker changed from Issue to Task
  • % Done set to 0
  • Tags Plugin Template added
Actions
Copy link
 #2

Updated by daviddavis over 5 years ago

  • Status changed from NEW to POST
  • Assignee set to daviddavis

Added by daviddavis over 5 years ago

Revision 1beee2cd | View on GitHub

HEAD^2 considered harmful

In certain cases, HEAD^2 can be undefined. Use git log --no-merges instead.

fixes #5010

Actions
Copy link
 #3

Updated by daviddavis over 5 years ago

  • Status changed from POST to MODIFIED
  • % Done changed from 0 to 100
Actions
Copy link
 #4

Updated by bmbouter about 5 years ago

  • Sprint/Milestone set to 3.0.0
Actions
Copy link
 #5

Updated by bmbouter about 5 years ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE
Actions
Send by e-mail Copy link

Also available in: Atom PDF