Project

Profile

Help

Refactor #4923

Document and refactor depsolving code

Added by dalley 6 months ago. Updated 5 months ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
Category:
-
Sprint/Milestone:
Start date:
Due date:
% Done:

100%

Platform Release:
2.20.0
Blocks Release:
Groomed:
No
Sprint Candidate:
No
Tags:
Pulp 2
Complexity:
Verified:
No
Verification Required:
No
Sprint:

Description

Most of it is poorly documented, and poorly adheres to separation of concerns, which makes it difficult to maintain, and difficult to understand, and will make it difficult to port over to Pulp 3 later on.

https://github.com/pulp/pulp_rpm/pull/1367


Related issues

Blocks RPM Support - Refactor #5068: Refactor depsolving code CLOSED - CURRENTRELEASE Actions

Associated revisions

Revision b2ecaa5a View on GitHub
Added by dalley 6 months ago

Refactoring for code clarity

This code is very difficult to follow. Here are some improvements that
make it more comprehensible.

  • Add docstrings
  • Rename functions to have more descriptive names
  • Turn methods that do not need to be methods into functions
  • Separate the concerns of performing depsolving and loading data from
    the database

re: #4693
https://pulp.plan.io/issues/4693
closes: #4923
https://pulp.plan.io/issues/4923

History

#1 Updated by dalley 6 months ago

  • Status changed from POST to MODIFIED
  • % Done changed from 0 to 100

#2 Updated by ttereshc 6 months ago

  • Sprint/Milestone set to 2.20.0

#3 Updated by dalley 5 months ago

#4 Updated by ttereshc 5 months ago

  • Status changed from MODIFIED to ON_QA

#5 Updated by ttereshc 5 months ago

  • Status changed from ON_QA to CLOSED - CURRENTRELEASE

Please register to edit this issue

Also available in: Atom PDF