Refactor #4923: Document and refactor depsolving code - RPM Support - Pulp

Send by e-mail

Refactor #4923

Document and refactor depsolving code

Added by dalley almost 2 years ago. Updated almost 2 years ago.

Status:

CLOSED - CURRENTRELEASE

Priority:

Normal

Assignee:

dalley

Sprint/Milestone:

Pulp - 2.20.0

Start date:

Due date:

% Done:

100%

Estimated time:

Platform Release:

2.20.0

Groomed:

Sprint Candidate:

Tags:

Pulp 2

Sprint:

Quarter:

Description

Most of it is poorly documented, and poorly adheres to separation of concerns, which makes it difficult to maintain, and difficult to understand, and will make it difficult to port over to Pulp 3 later on.

https://github.com/pulp/pulp_rpm/pull/1367

Related issues

Associated revisions

Revision b2ecaa5a View on GitHub
Added by dalley almost 2 years ago

Refactoring for code clarity

This code is very difficult to follow. Here are some improvements that make it more comprehensible.

Add docstrings
Rename functions to have more descriptive names
Turn methods that do not need to be methods into functions
Separate the concerns of performing depsolving and loading data from the database

re: #4693 https://pulp.plan.io/issues/4693 closes: #4923 https://pulp.plan.io/issues/4923