Project

Profile

Help

Actions
Send by e-mail Copy link

Refactor #4923

closed

Document and refactor depsolving code

Added by dalley almost 5 years ago. Updated almost 5 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
dalley
Sprint/Milestone:
Pulp - 2.20.0
Start date:
Due date:
% Done:

100%

Estimated time:
Platform Release:
2.20.0
Groomed:
No
Sprint Candidate:
No
Tags:
Pulp 2
Sprint:
Quarter:

Description

Most of it is poorly documented, and poorly adheres to separation of concerns, which makes it difficult to maintain, and difficult to understand, and will make it difficult to port over to Pulp 3 later on.

https://github.com/pulp/pulp_rpm/pull/1367

Related issues

Blocks RPM Support - Refactor #5068: Refactor depsolving codeCLOSED - CURRENTRELEASEdalley

Actions

Added by dalley almost 5 years ago

Revision b2ecaa5a | View on GitHub

Refactoring for code clarity

This code is very difficult to follow. Here are some improvements that make it more comprehensible.

  • Add docstrings
  • Rename functions to have more descriptive names
  • Turn methods that do not need to be methods into functions
  • Separate the concerns of performing depsolving and loading data from the database

re: #4693 https://pulp.plan.io/issues/4693 closes: #4923 https://pulp.plan.io/issues/4923

Actions
Copy link
 #1

Updated by dalley almost 5 years ago

  • Status changed from POST to MODIFIED
  • % Done changed from 0 to 100
Actions
Copy link
 #2

Updated by ttereshc almost 5 years ago

  • Sprint/Milestone set to 2.20.0
Actions
Copy link
 #3

Updated by dalley almost 5 years ago

Actions
Copy link
 #4

Updated by ttereshc almost 5 years ago

  • Status changed from MODIFIED to 5
Actions
Copy link
 #5

Updated by ttereshc almost 5 years ago

  • Status changed from 5 to CLOSED - CURRENTRELEASE
Actions
Send by e-mail Copy link

Also available in: Atom PDF