Project

Profile

Help

Task #4894

closed

Add check to Travis Configuration Tool to ensure the plugin never imports from pulpcore except pulpcore.plugin

Added by bmbouter almost 5 years ago. Updated almost 4 years ago.

Status:
CLOSED - COMPLETE
Priority:
Normal
Assignee:
Category:
-
Sprint/Milestone:
-
Start date:
Due date:
% Done:

100%

Estimated time:
Platform Release:
Groomed:
No
Sprint Candidate:
No
Tags:
Plugin Template
Sprint:
Quarter:

Description

To use the plugin API correctly, you should only be importing things from pulpcore.plugin. A check should be added (defaults to on) to fail Travis tests (both merge and pre-release pipelines) if there is an import statement to pulpcore that is not pulpcore.plugin.

Actions #1

Updated by daviddavis about 4 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to daviddavis

Added by daviddavis almost 4 years ago

Revision 6bb6854e | View on GitHub

Adding script to check for non-plugin pulpcore imports

fixes #4894

Actions #2

Updated by daviddavis almost 4 years ago

  • Status changed from ASSIGNED to MODIFIED
  • % Done changed from 0 to 100
Actions #3

Updated by daviddavis almost 4 years ago

  • Status changed from MODIFIED to CLOSED - COMPLETE

Also available in: Atom PDF