Project

Profile

Help

Issue #4746

closed

Do not query saved content in QueryExistingContents stage

Added by gmbnomis over 5 years ago. Updated almost 5 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
Category:
-
Sprint/Milestone:
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
OS:
Triaged:
No
Groomed:
No
Sprint Candidate:
No
Tags:
Easy Fix
Sprint:
Quarter:

Description

Motivation

Plugins may have multiple stages that query content. In
pulp_cookbook there is a custom stage that queries content and artifact from
the previous repo version. In immediate mode, the stages are:

...
QueryExistingRepoContentAndArtifacts(new_version=new_version),
ArtifactDownloader(),
ArtifactSaver(),
UpdateContentWithDownloadResult(),  # add digest to content
QueryExistingContents(),  # share content with known digest
...

After downloading missing artifacts (and thus, obtaining a digest), the
QueryExistingContents stage is used to identify content that already exists
outside of the repo. In this scenario, QueryExistingContents may encounter
already saved content which it should not query again for performance reasons.

Solution

Do as the current documentation states ('This stage inspects any "unsaved"
Content unit objects and searches for existing saved Content units inside
Pulp with the same unit key') and do not query for content that is already
saved.

Also available in: Atom PDF