Project

Profile

Help

Refactor #4336

closed

Refactoring the download stage

Added by mdellweg over 5 years ago. Updated over 4 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
Category:
-
Sprint/Milestone:
Start date:
Due date:
% Done:

100%

Estimated time:
Platform Release:
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:
Quarter:

Description

While experimenting with failsafe DeclarativeArtifacts, a discussion [0] came up that the ArtifactStage does not use the right level of abstraction.
In the current implementation, it works at the DeclarativeContent level and creates downloader coroutines to be run afterwards. After obtaining the download results, an expensive lookup of the corresponding DeclarativeArtifacts is performed in order to update them.

Proposed refactoring:
Move creating download coroutines, running them and updating the associated Artifact to a coroutine `download` in the class DeclarativeArtifacts. All neccesary information is already there.

[0] https://github.com/pulp/pulpcore-plugin/pull/30#issuecomment-452919468

Actions #1

Updated by bmbouter over 5 years ago

  • Status changed from NEW to POST
Actions #2

Updated by mdellweg over 5 years ago

  • Status changed from POST to MODIFIED
  • % Done changed from 0 to 100

Applied in changeset commit:pulpcore-plugin|aaa38d16e92a745414ac0ff848bd09f92d747dcf.

Actions #3

Updated by daviddavis about 5 years ago

  • Tags Pulp 3 added
Actions #4

Updated by daviddavis almost 5 years ago

  • Sprint/Milestone set to 3.0.0
Actions #5

Updated by bmbouter almost 5 years ago

  • Tags deleted (Pulp 3)
Actions #6

Updated by bmbouter over 4 years ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE

Also available in: Atom PDF