Refactor #4336
closedRefactoring the download stage
100%
Description
While experimenting with failsafe DeclarativeArtifacts, a discussion [0] came up that the ArtifactStage does not use the right level of abstraction.
In the current implementation, it works at the DeclarativeContent level and creates downloader coroutines to be run afterwards. After obtaining the download results, an expensive lookup of the corresponding DeclarativeArtifacts is performed in order to update them.
Proposed refactoring:
Move creating download coroutines, running them and updating the associated Artifact to a coroutine `download` in the class DeclarativeArtifacts. All neccesary information is already there.
[0] https://github.com/pulp/pulpcore-plugin/pull/30#issuecomment-452919468
Updated by bmbouter almost 6 years ago
- Status changed from NEW to POST
PR available at: https://github.com/pulp/pulpcore-plugin/pull/32
Updated by mdellweg almost 6 years ago
- Status changed from POST to MODIFIED
- % Done changed from 0 to 100
Applied in changeset commit:pulpcore-plugin|aaa38d16e92a745414ac0ff848bd09f92d747dcf.
Updated by bmbouter about 5 years ago
- Status changed from MODIFIED to CLOSED - CURRENTRELEASE