Project

Profile

Help

Issue #4091

closed

The master branch is failing

Added by daviddavis over 5 years ago. Updated about 4 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
High
Assignee:
Category:
-
Sprint/Milestone:
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:
Sprint 44
Quarter:

Description

Example:

https://travis-ci.org/pulp/pulp/builds/443310599

I believe it's probably due to the new version of DRF (3.9.0) which just came out today.

Actions #1

Updated by dalley over 5 years ago

  • Triaged changed from No to Yes
  • Sprint set to Sprint 44
  • Tags Pulp 3 added
Actions #2

Updated by daviddavis over 5 years ago

Looks like with DRF 3.8, you get a json response when you hit the base url (/pulp/api/v3/). Now with 3.9, we get:

info:
  description: ''
  title: Pulp API
  version: ''
openapi: 3.0.0
paths: {}
servers:
- url: http://localhost:8000/pulp/api/v3/

pulp-smash is hitting this base url to test authentication and they are expecting back json.

From the release notes that dalley posted:

The get_schema_view(...) method now defaults to OpenAPI YAML, with CoreJSON as a secondary option if it is selected via HTTP content negotiation.

Actions #3

Updated by daviddavis over 5 years ago

I don't think using the base_url is a good test for authentication. It doesn't require a user necessarily and it's not something we've intentionally created in our application. I think something like /pulp/api/v3/users/ might be better.

Actions #4

Updated by daviddavis over 5 years ago

  • Status changed from NEW to POST
  • Assignee set to daviddavis

Added by daviddavis over 5 years ago

Revision 9c29ece0 | View on GitHub

Use /pulp/api/v3/users to test auth

I don't think using the /pulp/api/v3/ is a good test for authentication. It doesn't require a user necessarily and it's not something we've intentionally created in our application. I think something like /pulp/api/v3/users/ might be better.

fixes #4091 https://pulp.plan.io/issues/4091

Added by daviddavis over 5 years ago

Revision 9c29ece0 | View on GitHub

Use /pulp/api/v3/users to test auth

I don't think using the /pulp/api/v3/ is a good test for authentication. It doesn't require a user necessarily and it's not something we've intentionally created in our application. I think something like /pulp/api/v3/users/ might be better.

fixes #4091 https://pulp.plan.io/issues/4091

Actions #5

Updated by daviddavis over 5 years ago

  • Status changed from POST to MODIFIED
Actions #6

Updated by daviddavis almost 5 years ago

  • Sprint/Milestone set to 3.0.0
Actions #7

Updated by bmbouter almost 5 years ago

  • Tags deleted (Pulp 3)
Actions #8

Updated by bmbouter about 4 years ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE

Also available in: Atom PDF