Issue #3539
closedInstall drf_openapi when installing pulp3
Description
Right now, in order to have access to auto generated docs, it is necessary an extra step to install drf_openapi
pip3 install -e git+https://github.com/limdauto/drf_openapi.git@54d24fb#egg=drf_openapi
I would like to suggest this extra step to be removed, and drf_openapi be installed together with pulp.
Related issues
Updated by bizhang over 6 years ago
I suggest we use setuptools' extra_requires module [0]
Users can then install pulp like: pip install pulpcore['autodocs'] if they wish for pulpcore with autodocs, and pip install pulpcore if they do not
Updated by daviddavis over 6 years ago
- Groomed changed from No to Yes
- Sprint Candidate changed from No to Yes
Updated by daviddavis over 6 years ago
- Groomed changed from Yes to No
- Sprint Candidate changed from Yes to No
bizhang, does this also work when installing pulpcore from source?
Updated by bizhang over 6 years ago
Yep!
pip install -e .['test']
for local installs
pip3 install -e "git+https://github.com/werwty/pulp.git@3.0-dev#egg=pulpcore[test]&subdirectory=plugin"
for remote
Updated by bizhang over 6 years ago
- Related to Task #3533: Prepare for pypi pulp3 beta release added
Updated by bmbouter over 6 years ago
In terms of a mechanism, I think having the optional setuptools approach is right.
I also want to hear feedback on this question: should all Pulp installations ship with local API docs by default?
Updated by daviddavis over 6 years ago
I also want to hear feedback on this question: should all Pulp installations ship with local API docs by default?
Seems easier to just have a central place for users to see their api schema for their particular set up rather than having to hunt down the docs online for core, plugins, etc; and then have to look up what versions of things that are being used, etc.
Are there any downsides?
Updated by dalley over 6 years ago
- Triaged changed from No to Yes
- Sprint set to Sprint 35
- Tags Easy Fix added
Updated by bizhang over 6 years ago
When I think of dependencies I think of things that pulp must have in order to run.
Tools like drf_openapi/drf_yawg is nice to have but not necessary; the schema is still available to the user when they GET /api/v3/; all this optional dependencies provide is a nice UI wrapper on top.
Updated by dalley over 6 years ago
- Status changed from NEW to ASSIGNED
- Assignee set to dalley
Updated by dalley over 6 years ago
- Status changed from ASSIGNED to POST
Updated by dalley over 6 years ago
- Status changed from POST to CLOSED - WONTFIX
Updated by dalley over 6 years ago
Superceded by: https://pulp.plan.io/issues/3552
Updated by dalley over 6 years ago
- Assignee deleted (
dalley) - Sprint deleted (
Sprint 35)