Issue #3410
closed
Rename content field "path" to "relative_path"
Status:
CLOSED - CURRENTRELEASE
Description
When reading content from a repository, the response is:
{'next': None,
'previous': None,
'results': [{'_href': 'http://f27-p3:8000/api/v3/content/file/44f4dfa2-1b80-459c-960b-079c4dd6e48c/',
'artifacts': {'2.iso': 'http://f27-p3:8000/api/v3/artifacts/cbce4558-59b9-4674-83d2-7f6dd2875b6e/'},
'digest': '3a1b7f18cb8e51f381a9ceb32447fcdaa070d41bbf2d9bd12f5ea1731dfe0b0b',
'notes': {},
'path': '2.iso',
'type': 'file'}]}
</code>
"path" should be renamed to "relative_path" to better denote its purpose.
I believe "path" is actually short for "relative_path" and that with more complex plugins with directories you would indeed have some which are not just the standalone filename. This isn't apparent with the file plugin because it doesn't do anything like that.
I agree that maybe this should be made explicit.
+1 rename to relative_path
- Subject changed from Rename variable path to name - reading content from a repository to Rename variable path to relative_name when reading content from a repository
- Subject changed from Rename variable path to relative_name when reading content from a repository to Rename variable path to relative_path when reading content from a repository
- Description updated (diff)
- Triaged changed from No to Yes
- Project changed from Pulp to File Support
- Subject changed from Rename variable path to relative_path when reading content from a repository to Rename content field "path" to "relative_path"
- Sprint/Milestone set to 56
- Status changed from NEW to ASSIGNED
- Assignee set to daviddavis
- Related to Issue #3425: Path on content unit doesn't seem to do anything added
- Status changed from ASSIGNED to POST
- Status changed from POST to MODIFIED
- Sprint/Milestone deleted (
56)
- Sprint/Milestone set to 0.1.0
- Status changed from MODIFIED to CLOSED - CURRENTRELEASE
Also available in: Atom
PDF
Limit FileContent api fields to path and artifact
This solves a number of issues such as differences between digest on FileContent vs Artifact.sha256, and FileContent.relative_path vs ContentArtifact.relative_path.
This also renames FileContent.path to FileContent.relative_path
fixes #3428, #3410 https://pulp.plan.io/issues/3428 https://pulp.plan.io/issues/3410