Project

Profile

Help

Issue #3410

Rename content field "path" to "relative_path"

Added by kersom over 3 years ago. Updated almost 2 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Low
Assignee:
Sprint/Milestone:
Start date:
Due date:
Estimated time:
Severity:
1. Low
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Documentation
Sprint:
Sprint 33
Quarter:

Description

When reading content from a repository, the response is:

 {'next': None,
 'previous': None,
 'results': [{'_href': 'http://f27-p3:8000/api/v3/content/file/44f4dfa2-1b80-459c-960b-079c4dd6e48c/',
              'artifacts': {'2.iso': 'http://f27-p3:8000/api/v3/artifacts/cbce4558-59b9-4674-83d2-7f6dd2875b6e/'},
              'digest': '3a1b7f18cb8e51f381a9ceb32447fcdaa070d41bbf2d9bd12f5ea1731dfe0b0b',
              'notes': {},
              'path': '2.iso',
              'type': 'file'}]}

</code>

"path" should be renamed to "relative_path" to better denote its purpose.


Checklist


Related issues

Related to File Support - Issue #3425: Path on content unit doesn't seem to do anythingCLOSED - DUPLICATE<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>

Associated revisions

Revision 30afa7cc View on GitHub
Added by daviddavis over 3 years ago

Limit FileContent api fields to path and artifact

This solves a number of issues such as differences between digest on FileContent vs Artifact.sha256, and FileContent.relative_path vs ContentArtifact.relative_path.

This also renames FileContent.path to FileContent.relative_path

fixes #3428, #3410 https://pulp.plan.io/issues/3428 https://pulp.plan.io/issues/3410

History

#1 Updated by dalley over 3 years ago

I believe "path" is actually short for "relative_path" and that with more complex plugins with directories you would indeed have some which are not just the standalone filename. This isn't apparent with the file plugin because it doesn't do anything like that.

I agree that maybe this should be made explicit.

#2 Updated by amacdona@redhat.com over 3 years ago

+1 rename to relative_path

#3 Updated by bmbouter over 3 years ago

+1 to relative_path

#4 Updated by bmbouter over 3 years ago

  • Subject changed from Rename variable path to name - reading content from a repository to Rename variable path to relative_name when reading content from a repository

#5 Updated by dalley over 3 years ago

  • Subject changed from Rename variable path to relative_name when reading content from a repository to Rename variable path to relative_path when reading content from a repository
  • Description updated (diff)
  • Triaged changed from No to Yes

#6 Updated by amacdona@redhat.com over 3 years ago

  • Project changed from Pulp to File Support
  • Subject changed from Rename variable path to relative_path when reading content from a repository to Rename content field "path" to "relative_path"
  • Sprint/Milestone set to 56

#7 Updated by daviddavis over 3 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to daviddavis

#8 Updated by daviddavis over 3 years ago

  • Related to Issue #3425: Path on content unit doesn't seem to do anything added

#9 Updated by daviddavis over 3 years ago

  • Status changed from ASSIGNED to POST

#10 Updated by daviddavis over 3 years ago

  • Status changed from POST to MODIFIED

#11 Updated by bmbouter over 3 years ago

  • Sprint set to Sprint 33

#12 Updated by bmbouter over 3 years ago

  • Sprint/Milestone deleted (56)

#13 Updated by bmbouter over 2 years ago

  • Tags deleted (Pulp 3)

#14 Updated by bmbouter almost 2 years ago

  • Sprint/Milestone set to 0.1.0

#15 Updated by bmbouter almost 2 years ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE

Please register to edit this issue

Also available in: Atom PDF