Task #3375
closedUpdate psycopg2 dependency to psycopg2-binary
100%
Description
The psycopg2[0] package is going to move their wheels files to psycopg2-binary when version 2.8 is released.
We should switch our dependency to psycopg2-binary[1]. The wheel installation is self contained, and does not need external runtime dependencies [2] installed.
[0] https://pypi.python.org/pypi/psycopg2/2.7.4
[1] https://github.com/pulp/pulp/blob/3.0-dev/pulpcore/setup.py#L13
[2] http://initd.org/psycopg/docs/install.html#runtime-requirements
Related issues
Updated by bizhang over 6 years ago
- Related to Task #3533: Prepare for pypi pulp3 beta release added
Updated by dalley over 6 years ago
The PyPI landing page for psychopg2-binary says the following, FWIW:
The binary package is a practical choice for development and testing but in production it is advised to use the package built from sources.
Updated by bizhang over 6 years ago
The reason psycopg2-binary was separated from psycopg2 is because of occasional errors that resulted from different versions of libssl being imported by psycopg2-binary and by urllib/requests. [0]
Pulp does not use urlib nor requests to open https connections (AFAICT asyncio does not use libssl)
I think we should separate out this dependency for rpm packages and pypi packages. We have no way of ensuring the existence of build tools and runtime libraries on the client with python only dependencies.
We should work with the build team to ensure that the necessary build dependencies [1] for psycopg2 exist for the RPM package and depend on a source build for our rpm package, but continue using the binary for pypi installs
[0] http://initd.org/psycopg/articles/2018/02/08/psycopg-274-released
[1] http://initd.org/psycopg/docs/install.html#build-prerequisites
Updated by bizhang over 6 years ago
- Status changed from NEW to POST
- Assignee set to bizhang
Added by werwty over 6 years ago
Added by werwty over 6 years ago
Revision bfd74c7f | View on GitHub
Prep for pulp3 beta release
https://pulp.plan.io/issues/3533 https://pulp.plan.io/issues/3375
Updated by bizhang over 6 years ago
I've mentioned this to pcreech, he pointed out that psycopg2 already has a rpm built: https://buildlogs.centos.org/centos/7/sclo/x86_64/rh/rh-python36/
and we can just depend on that for our rpm :)
Updated by werwty over 6 years ago
- Status changed from POST to MODIFIED
- % Done changed from 0 to 100
Applied in changeset pulp|bfd74c7fd92d8e125e79647f7ceeeb357a748423.
Updated by bmbouter almost 5 years ago
- Status changed from MODIFIED to CLOSED - CURRENTRELEASE
Prep for pulp3 beta release
closes #3533 closes #3375
https://pulp.plan.io/issues/3533 https://pulp.plan.io/issues/3375