Actions
Issue #3270
closedImprove exception handling for incorrect feed_url
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Easy Fix
Sprint:
Sprint 31
Quarter:
Description
For the File plugin, the feed_url points to the manifest file, rather than the directory. Other plugins use the directory, so it is likely that others will make this mistake also.
WRONG:
feed_url = https://repos.fedorapeople.org/pulp/pulp/fixtures/file/
RIGHT:
feed_url = https://repos.fedorapeople.org/pulp/pulp/fixtures/file/PULP_MANIFEST
This issue is to impove the exception handling, because it was tricky to debug.
Some notes:
- os.path.basename returns "" when passed a string that ends with "/"
- os.makedirs ignores the working directory when passed a string that starts with "/"
- the combination of ^ means that using WRONG feed_url results in a PermissionsError, trying to write to /pulp/pulp/fixtures/file/
Updated by amacdona@redhat.com almost 7 years ago
- Subject changed from Bad exception for incorrect feed_url to Improve exception handling for incorrect feed_url
Updated by dalley almost 7 years ago
- Sprint/Milestone set to 53
- Triaged changed from No to Yes
Updated by jortel@redhat.com almost 7 years ago
Easy fix: just need to rstrip('/') string passed to basename().
Updated by jortel@redhat.com almost 7 years ago
- Status changed from NEW to ASSIGNED
- Assignee set to jortel@redhat.com
- Tags Easy Fix, Pulp 3 added
Added by jortel@redhat.com almost 7 years ago
Updated by jortel@redhat.com almost 7 years ago
- Status changed from ASSIGNED to POST
Updated by jortel@redhat.com almost 7 years ago
- Status changed from POST to MODIFIED
Applied in changeset 9f995eebda6c353f48463b9fd78042ca777f7790.
Updated by bmbouter about 5 years ago
- Status changed from MODIFIED to CLOSED - CURRENTRELEASE
Actions
Use asyncio downloader. closes #3270, closes #3272