Refactor #3151
closed
Pulp3 server.yaml configuration names should be standardized
0%
Description
Currently we have a mix of casenames in the server.yaml.
the JWT settings are capitalized, and the rest of things are all lowercased. [0]
Django requires all settings to be uppercase [1], we do that right now by converting the settings to uppercase on load time [2]
Personally I've not seen any yaml file with UPPERCASE settings so that might be unconventional, and what we're doing might be the right thing. In any case we should standardize our config names, whether through lowercasing the JWT configs, or capitalizing the rest of the settings
[0] https://github.com/pulp/pulp/blob/961529a3ef67dbce8d49bc45e09dfd5da2171f86/pulpcore/pulpcore/etc/pulp/server.yaml
[1] https://docs.djangoproject.com/en/1.11/topics/settings/#creating-your-own-settings
[2] https://github.com/pulp/pulp/blob/961529a3ef67dbce8d49bc45e09dfd5da2171f86/pulpcore/pulpcore/app/settings.py#L285
Related issues
Updated by dalley over 6 years ago
Since the JWT code has been removed, the only incongruity is the SECRET_KEY variable, which I'm not sure we can do anything about since Django is looking for all-caps.
I propose we close-currentrelease or close-notabug
Updated by daviddavis over 6 years ago
- Related to Issue #3589: Settings in server.yaml have inconsistent names added
.