Project

Profile

Help

Refactor #3151

Pulp3 server.yaml configuration names should be standardized

Added by bizhang about 3 years ago. Updated almost 2 years ago.

Status:
CLOSED - NOTABUG
Priority:
Normal
Assignee:
-
Category:
-
Sprint/Milestone:
Start date:
Due date:
% Done:

0%

Estimated time:
Platform Release:
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:
Quarter:

Description

Currently we have a mix of casenames in the server.yaml.

the JWT settings are capitalized, and the rest of things are all lowercased. [0]
Django requires all settings to be uppercase [1], we do that right now by converting the settings to uppercase on load time [2]

Personally I've not seen any yaml file with UPPERCASE settings so that might be unconventional, and what we're doing might be the right thing. In any case we should standardize our config names, whether through lowercasing the JWT configs, or capitalizing the rest of the settings

[0] https://github.com/pulp/pulp/blob/961529a3ef67dbce8d49bc45e09dfd5da2171f86/pulpcore/pulpcore/etc/pulp/server.yaml
[1] https://docs.djangoproject.com/en/1.11/topics/settings/#creating-your-own-settings
[2] https://github.com/pulp/pulp/blob/961529a3ef67dbce8d49bc45e09dfd5da2171f86/pulpcore/pulpcore/app/settings.py#L285


Related issues

Related to Pulp - Issue #3589: Settings in server.yaml have inconsistent namesCLOSED - CURRENTRELEASE<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>

History

#1 Updated by daviddavis about 3 years ago

  • Tags Pulp 3 MVP added

#2 Updated by dalley almost 3 years ago

Since the JWT code has been removed, the only incongruity is the SECRET_KEY variable, which I'm not sure we can do anything about since Django is looking for all-caps.

I propose we close-currentrelease or close-notabug

#3 Updated by dalley almost 3 years ago

  • Status changed from NEW to CLOSED - NOTABUG

#4 Updated by dkliban@redhat.com almost 3 years ago

  • Sprint/Milestone set to 3.0.0

#5 Updated by daviddavis almost 3 years ago

  • Related to Issue #3589: Settings in server.yaml have inconsistent names added

#6 Updated by bmbouter almost 2 years ago

  • Tags deleted (Pulp 3, Pulp 3 MVP)

Please register to edit this issue

Also available in: Atom PDF