Project

Profile

Help

Issue #2960

UnicodeEncodeError in case of a non-ASCII character in comments provided with SSL cert/key/CA

Added by ttereshc over 4 years ago. Updated almost 2 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version - Nectar:
Platform Release:
2.14.2
Target Release - Nectar:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
Yes
Tags:
Pulp 2
Sprint:
Quarter:

Description

File "/usr/lib/python2.7/site-packages/celery/app/trace.py", line 240, in trace_task
        R = retval = fun(*args, **kwargs)
      File "/usr/lib/python2.7/site-packages/pulp/server/async/tasks.py", line 473, in __call__
        return super(Task, self).__call__(*args, **kwargs)
      File "/usr/lib/python2.7/site-packages/pulp/server/async/tasks.py", line 103, in __call__
        return super(PulpTask, self).__call__(*args, **kwargs)
      File "/usr/lib/python2.7/site-packages/celery/app/trace.py", line 437, in __protected_call__
        return self.run(*args, **kwargs)
      File "/usr/lib/python2.7/site-packages/pulp/server/controllers/repository.py", line 762, in sync
        sync_report = sync_repo(transfer_repo, conduit, call_config)
      File "/usr/lib/python2.7/site-packages/pulp/server/async/tasks.py", line 658, in wrap_f
        return f(*args, **kwargs)
      File "/usr/lib/python2.7/site-packages/pulp_rpm/plugins/importers/yum/importer.py", line 80, in sync_repo
        self._current_sync = sync.RepoSync(repo, sync_conduit, call_config)
      File "/usr/lib/python2.7/site-packages/pulp_rpm/plugins/importers/yum/sync.py", line 86, in __init__
        self.nectar_config = nectar_utils.importer_config_to_nectar_config(config.flatten())
      File "/usr/lib/python2.7/site-packages/pulp/plugins/util/nectar_config.py", line 97, in importer_config_to_nectar_config
        download_config = DownloaderConfig(**download_config_kwargs)
      File "/usr/lib/python2.7/site-packages/nectar/config.py", line 136, in __init__
        self._process_ssl_settings()
      File "/usr/lib/python2.7/site-packages/nectar/config.py", line 175, in _process_ssl_settings
        os.write(data_arg_os_handle, data_arg_value)
    UnicodeEncodeError: 'ascii' codec can't encode character u'\xe9' in position 76773: ordinal not in range(128)

It happens when Nectar is trying to write a provided SSL cert/key/CA on a disk.

Associated revisions

Revision e0863db8 View on GitHub
Added by Ammar over 4 years ago

UnicodeEncodeError in comments provided with SSL cert/key/CA

A UnicodeError was being raised if non-ascii characters were present in comments provided with SSL cert/key/CA

closes #2960

Revision ec86ae5a View on GitHub
Added by Michael Hrivnak over 4 years ago

Revert "UnicodeEncodeError in comments provided with SSL cert/key/CA"

Revision db4adfdd View on GitHub
Added by Ammar over 4 years ago

UnicodeEncodeError in comments provided with SSL cert/key/CA

A UnicodeError was being raised if non-ascii characters were present in comments provided with SSL cert/key/CA

closes #2960

Revision 010753eb View on GitHub
Added by Ammar over 4 years ago

UnicodeEncodeError in comments provided with SSL cert/key/CA

This is an additional fix needed in Pulp apart from https://github.com/pulp/nectar/pull/63, since Pulp writes out the SSL certs to a different path than nectar

closes #2960

History

#1 Updated by ttereshc over 4 years ago

  • Triaged changed from No to Yes

#2 Updated by daviddavis over 4 years ago

This bug was prompted by https://bugzilla.redhat.com/show_bug.cgi?id=1449418. I'm unlinking the two though since it looks like downstream they're fixing it in Katello. We should still consider fixing this in pulp though.

#3 Updated by daviddavis over 4 years ago

  • Triaged changed from Yes to No

#4 Updated by ttereshc over 4 years ago

  • Triaged changed from No to Yes

#5 Updated by ttereshc over 4 years ago

  • Sprint Candidate changed from No to Yes

#8 Updated by mansari over 4 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to mansari

#9 Updated by mansari over 4 years ago

  • Status changed from ASSIGNED to POST
  • Assignee deleted (mansari)

#10 Updated by mansari over 4 years ago

  • Assignee set to mansari

#11 Updated by Anonymous over 4 years ago

  • Status changed from POST to MODIFIED

#12 Updated by mhrivnak over 4 years ago

  • Status changed from MODIFIED to ASSIGNED

This was mistakenly merged early. The merged code needs to be reverted, and then a new PR made.

Please make the new PR on 2.14-dev since it is a bug fix.

Thanks!

#13 Updated by mansari over 4 years ago

  • Status changed from ASSIGNED to POST

#14 Updated by Anonymous over 4 years ago

  • Status changed from POST to MODIFIED

#15 Updated by Anonymous over 4 years ago

#16 Updated by pcreech over 4 years ago

  • Platform Release set to 2.14.2

#17 Updated by pcreech over 4 years ago

  • Status changed from MODIFIED to 5

#18 Updated by pcreech over 4 years ago

  • Status changed from 5 to CLOSED - CURRENTRELEASE

#19 Updated by mansari about 4 years ago

  • Status changed from CLOSED - CURRENTRELEASE to ASSIGNED

#20 Updated by mansari about 4 years ago

  • Status changed from ASSIGNED to POST

#21 Updated by mansari about 4 years ago

  • Status changed from POST to CLOSED - CURRENTRELEASE

#22 Updated by bmbouter almost 3 years ago

  • Tags Pulp 2 added

Also available in: Atom PDF