Pulp

+1 to config, license, and docs. We need to disinclude the systemd parts because that is OS specific, so we can't ship it with the pure Python code. I think the Ansible installer will allow the "right thing" to be done on all the different OS's. So I imagine #2840 will handle installing the systemd units.

Note that the develop install roles (not #2840) will still install the systemd unit files since the development OS is Fedora. I think they should do that if they don't already.

Actually I'm not entirely sure how to ship the docs. Maybe we should leave those out for now too?

I don't have much experience with this, but from reading the docs, if we include them in MANIFEST.in they will install in the package's folder in site-packages. That would make that server.yaml file to install in /usr/lib/python3.5/site-packages/pulp/server.yaml.

Is there any way for us to specify that it live somewhere else in the filesystem?

That can be done with the data_files option in setup.py [0] However if we were to install it directly to /etc/pulp/server.yaml pip install would require sudo permissions.

I was thinking that if we include it in the MANIFEST.in the user would install it to {venv}/usr/lib/python3.5/site-packages/pulpcore/server.yaml
they can set a environmental variable to read it from there [1]

[0] https://packaging.python.org/tutorials/distributing-packages/#data-files
[1] https://pulp.plan.io/issues/2833

The config file should be included in the package_data instead of the MANIFEST.in since it should be included in the package and not just source distribution.

PR for core, common, and plugin: https://github.com/pulp/pulp/pull/3070/