Project

Profile

Help

Story #271

[RFE] builder.py should print an error and exit if it is run from the master branch

Added by cduryee almost 7 years ago. Updated almost 3 years ago.

Status:
CLOSED - WONTFIX
Priority:
Normal
Category:
-
Sprint/Milestone:
-
Start date:
Due date:
% Done:

0%

Estimated time:
Platform Release:
2.6.0
Groomed:
No
Sprint Candidate:
No
Tags:
Easy Fix, Pulp 2
Sprint:
Quarter:

Description

++ This bug was initially created as a clone of Bugzilla Bug #1166703 ++

Description of problem:

Description:

If you miss a step during the build setup process, you may accidentally run ./builder.py from the master branch. This is almost always incorrect; builder.py should run a branch like 2.6-dev or 2.4-release.

This bug is an RFE to print an error if builder.py is run from a git checkout that is currently on master. We can possibly add an override command-line option as well to allow builder.py to run from master if the user really wants to do that.

The "am I on master?" check should be performed before builder.py does anything else.

--- Additional comment from at 11/21/2014 14:39:32 ---

This seems reasonable. That override flag might be necessary if we want to have nightly builds.

--- Additional comment from at 12/03/2014 18:08:34 ---

https://github.com/pulp/pulp/pull/1387

--- Additional comment from at 12/23/2014 20:52:54 ---

fixed in pulp 2.6.0-0.2.beta

History

#1 Updated by bcourt almost 7 years ago

This is no longer an issue as the pulp/releng/builder.py script is no longer in use.

#2 Updated by cduryee almost 7 years ago

  • Status changed from 5 to CLOSED - WONTFIX

builder.py is no longer used, closing bz.

#3 Updated by bmbouter almost 3 years ago

  • Tags Pulp 2 added

Also available in: Atom PDF