Issue #2550: Publishing via rsync does not correctly look at publish records - Pulp

Actions

Send by e-mail Copy link

Issue #2550

closed

Publishing via rsync does not correctly look at publish records

Added by daviddavis almost 8 years ago. Updated over 5 years ago.

Status:

CLOSED - CURRENTRELEASE

Priority:

Normal

Assignee:

daviddavis

Category:

Sprint/Milestone:

Start date:

Due date:

Estimated time:

Severity:

2. Medium

Version:

Platform Release:

2.12.1

OS:

Triaged:

Yes

Groomed:

Sprint Candidate:

Tags:

Pulp 2

Sprint:

Sprint 15

Quarter:

Description

I noticed when perusing the code that this line:

https://github.com/pulp/pulp/blob/pulp-2.12.0-0.3.rc/server/pulp/plugins/rsync/publish.py#L307

Uses predistributor id (e.g. ObjectId("588b7df6418a8a1eaa5dafa1")) when it should be using distributor_id.

This means that force_full will not be automatically set to True if the predistributor publish was force_full=True or there was an error:

https://github.com/pulp/pulp/blob/pulp-2.12.0-0.3.rc/server/pulp/plugins/rsync/publish.py#L338-L343

Actions

Copy link

Updated by daviddavis almost 8 years ago

Blocks Issue #2532: rsync distributor without force_full incorrectly skips publishing some units added

Actions

Copy link

Updated by daviddavis almost 8 years ago

Blocks deleted (Issue #2532: rsync distributor without force_full incorrectly skips publishing some units)

Actions

Copy link

Updated by bizhang almost 8 years ago

Sprint/Milestone set to 32
Triaged changed from No to Yes

Actions

Copy link

Updated by daviddavis almost 8 years ago

Status changed from NEW to ASSIGNED
Assignee set to daviddavis

Actions

Copy link

Updated by daviddavis almost 8 years ago

Steps to reproduce:

1. Create a repo with a yum predistributor and a rsync distributor
2. Sync the repo so it has units
3. Do a pubilsh
4. Clear out the units in the rsync destination
5. Do another publish but cause an error in the yum publish
6. Fix error and do another publish
7. Check that a rsync publish occurred and that the units are back

Actions

Copy link