Issue #2550
closedPublishing via rsync does not correctly look at publish records
Description
I noticed when perusing the code that this line:
https://github.com/pulp/pulp/blob/pulp-2.12.0-0.3.rc/server/pulp/plugins/rsync/publish.py#L307
Uses predistributor id (e.g. ObjectId("588b7df6418a8a1eaa5dafa1")
) when it should be using distributor_id.
This means that force_full will not be automatically set to True if the predistributor publish was force_full=True or there was an error:
https://github.com/pulp/pulp/blob/pulp-2.12.0-0.3.rc/server/pulp/plugins/rsync/publish.py#L338-L343
Updated by daviddavis almost 8 years ago
- Blocks Issue #2532: rsync distributor without force_full incorrectly skips publishing some units added
Updated by daviddavis almost 8 years ago
- Blocks deleted (Issue #2532: rsync distributor without force_full incorrectly skips publishing some units)
Updated by bizhang almost 8 years ago
- Sprint/Milestone set to 32
- Triaged changed from No to Yes
Updated by daviddavis almost 8 years ago
- Status changed from NEW to ASSIGNED
- Assignee set to daviddavis
Updated by daviddavis almost 8 years ago
Steps to reproduce:
1. Create a repo with a yum predistributor and a rsync distributor
2. Sync the repo so it has units
3. Do a pubilsh
4. Clear out the units in the rsync destination
5. Do another publish but cause an error in the yum publish
6. Fix error and do another publish
7. Check that a rsync publish occurred and that the units are back
Updated by daviddavis almost 8 years ago
- Status changed from ASSIGNED to POST
Added by daviddavis almost 8 years ago
Added by daviddavis almost 8 years ago
Revision 8ea6a01e | View on GitHub
Filtering predistributor results by distributor_id
Fixing a bug where we were filtering predistributor publish results by predistributor id instead of distributor_id.
Updated by daviddavis almost 8 years ago
- Status changed from POST to MODIFIED
Applied in changeset pulp|8ea6a01e0d8fe0d654ac50eb38c88c946709b6fb.
Updated by bizhang almost 8 years ago
- Status changed from 5 to CLOSED - CURRENTRELEASE
Filtering predistributor results by distributor_id
Fixing a bug where we were filtering predistributor publish results by predistributor id instead of distributor_id.
fixes #2550 https://pulp.plan.io/issues/2550