Project

Profile

Help

Issue #2550

closed

Publishing via rsync does not correctly look at publish records

Added by daviddavis over 7 years ago. Updated about 5 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
Category:
-
Sprint/Milestone:
-
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
2.12.1
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Pulp 2
Sprint:
Sprint 15
Quarter:

Description

I noticed when perusing the code that this line:

https://github.com/pulp/pulp/blob/pulp-2.12.0-0.3.rc/server/pulp/plugins/rsync/publish.py#L307

Uses predistributor id (e.g. ObjectId("588b7df6418a8a1eaa5dafa1")) when it should be using distributor_id.

This means that force_full will not be automatically set to True if the predistributor publish was force_full=True or there was an error:

https://github.com/pulp/pulp/blob/pulp-2.12.0-0.3.rc/server/pulp/plugins/rsync/publish.py#L338-L343

Actions #1

Updated by daviddavis over 7 years ago

  • Blocks Issue #2532: rsync distributor without force_full incorrectly skips publishing some units added
Actions #2

Updated by daviddavis over 7 years ago

  • Blocks deleted (Issue #2532: rsync distributor without force_full incorrectly skips publishing some units)
Actions #3

Updated by bizhang over 7 years ago

  • Sprint/Milestone set to 32
  • Triaged changed from No to Yes
Actions #4

Updated by daviddavis over 7 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to daviddavis
Actions #5

Updated by daviddavis over 7 years ago

Steps to reproduce:

1. Create a repo with a yum predistributor and a rsync distributor
2. Sync the repo so it has units
3. Do a pubilsh
4. Clear out the units in the rsync destination
5. Do another publish but cause an error in the yum publish
6. Fix error and do another publish
7. Check that a rsync publish occurred and that the units are back

Actions #6

Updated by daviddavis over 7 years ago

  • Status changed from ASSIGNED to POST

Added by daviddavis over 7 years ago

Revision 8ea6a01e | View on GitHub

Filtering predistributor results by distributor_id

Fixing a bug where we were filtering predistributor publish results by predistributor id instead of distributor_id.

fixes #2550 https://pulp.plan.io/issues/2550

Added by daviddavis over 7 years ago

Revision 8ea6a01e | View on GitHub

Filtering predistributor results by distributor_id

Fixing a bug where we were filtering predistributor publish results by predistributor id instead of distributor_id.

fixes #2550 https://pulp.plan.io/issues/2550

Actions #8

Updated by mhrivnak over 7 years ago

  • Sprint/Milestone changed from 32 to 33
Actions #9

Updated by daviddavis over 7 years ago

  • Status changed from POST to MODIFIED
Actions #10

Updated by bizhang over 7 years ago

  • Platform Release set to 2.12.1
Actions #11

Updated by bizhang over 7 years ago

  • Status changed from MODIFIED to 5
Actions #12

Updated by bizhang over 7 years ago

  • Version set to 2.12.1
Actions #13

Updated by bizhang over 7 years ago

  • Version deleted (2.12.1)
Actions #14

Updated by bizhang about 7 years ago

  • Status changed from 5 to CLOSED - CURRENTRELEASE
Actions #15

Updated by bmbouter about 6 years ago

  • Sprint set to Sprint 15
Actions #16

Updated by bmbouter about 6 years ago

  • Sprint/Milestone deleted (33)
Actions #17

Updated by bmbouter about 5 years ago

  • Tags Pulp 2 added

Also available in: Atom PDF